Bug 7965 - Stray "No error" in client log with smart card auth
Summary: Stray "No error" in client log with smart card auth
Status: NEW
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Smart card (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: LowPrio
Assignee: Bugzilla mail exporter
Depends on:
Reported: 2022-07-07 16:07 CEST by Pierre Ossman
Modified: 2022-07-12 12:36 CEST (History)
0 users

See Also:
Acceptance Criteria:


Description Pierre Ossman cendio 2022-07-07 16:07:08 CEST
I'm getting a weird "No error" log line in tlclient.log when using smart card authentication:

> 2022-07-07T14:32:12: Calling XML-RPC method 'reconnect_session'
> 2022-07-07T14:32:12:  Response: 0: Success
> 2022-07-07T14:32:12: WinProcess: Process 2392 (ssh.exe) did not exit in a timely manner. Forcing termination...
> 2022-07-07T14:32:12: No error

Only happens on Windows for some reason though, and only with smart card authentication enabled.

No idea where it comes from. There is no prefix, so it must be from tlclient itself somewhere. I've checked the source tree without finding this string. 

Perhaps from the system for checking up error code 0?
Comment 1 Pierre Ossman cendio 2022-07-08 09:41:30 CEST
Found it. We have this log line in the socket code that triggers on read errors:

>         logfile.Log(strerror(errno), 2);

Using errno and strerror() for socket errors on Windows is incorrect (bug 7967), hence the odd "No error". But this line should also have some context, not just the error itself.

The actual error is 10054, i.e. ECONNRESET. I think this is the agent socket to ssh, as it happens right after we kill ssh (because of bug 1778).

Note You need to log in before you can comment on or make changes to this bug.