Bug 7952 - Initial background doesn't follow monitor layout
Summary: Initial background doesn't follow monitor layout
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Misc (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.15.0
Assignee: Samuel Mannehed
URL:
Keywords: frifl_tester, prosaic
Depends on:
Blocks:
 
Reported: 2022-06-23 09:54 CEST by Pierre Ossman
Modified: 2023-08-09 16:59 CEST (History)
2 users (show)

See Also:
Acceptance Criteria:
MUST: * The background should fit the largest monitor. * The configuration parameter documentation should be updated. COULD: * The background should fit all individual monitors regardless of size or position. * The background should update when monitor configuration is changed.


Attachments
The background overlaps to the next monitor (583.41 KB, image/png)
2023-08-08 11:35 CEST, Frida Flodin
Details
The Thinlinc logo is too far to the right (291.89 KB, image/png)
2023-08-08 11:47 CEST, Frida Flodin
Details

Description Pierre Ossman cendio 2022-06-23 09:54:08 CEST
The norm these days is that a background is sized to each individual monitor. However, this is not how ThinLinc's initial background is set. It completely ignores the monitor information and just stretches the image over the entire framebuffer. This generally looks rather bad, as the proportions are extremely far away from the backgrounds original proportions.
Comment 1 Pierre Ossman cendio 2022-06-23 09:54:50 CEST
Also note that bug 7218 is probably needed to have access to the correct monitor information.
Comment 5 Samuel Mannehed cendio 2023-08-04 13:59:56 CEST
This should be all done now. Tested server build 3343 on Ubuntu 22.04 and Fedora 38:

> MUST:
> * The background should fit the largest monitor
It does, it also fits all other monitors.

> COULD:
> * The background should fit all individual monitors regardless of size or position
It does, tested with 3 different monitors. I tested different combinations where all 3 had different resolutions, positions, and orientations.

> * The background should update when monitor configuration is changed
It does, thanks to the fact that we get a Randr event when this happens.
Comment 6 Samuel Mannehed cendio 2023-08-04 14:04:37 CEST
The TAG says:

> /sessionstart/background_image
> A PNG image used as the initial background. The image will always be scaled to cover the entire screen.
This should be updated now that the image fits each monitor.
Comment 9 Frida Flodin cendio 2023-08-08 11:35:21 CEST
Created attachment 1149 [details]
The background overlaps to the next monitor

Easy to miss depending on the order of the monitors. In this example, I shifted one monitor vertically. The left background overlaps the right.
Comment 10 Frida Flodin cendio 2023-08-08 11:47:42 CEST
Created attachment 1150 [details]
The Thinlinc logo is too far to the right

Also now when the monitor size is too narrow for the background, the Thinlinc logo looks displaced. It should be more to the left, I think.
Comment 14 Samuel Mannehed cendio 2023-08-09 13:26:53 CEST
The overlap issue, and centering of the background image, have now been fixed.
Comment 15 Frida Flodin cendio 2023-08-09 13:47:47 CEST
Tested again and it looks better with the centering. Tested with two monitors, no overlap.

Note You need to log in before you can comment on or make changes to this bug.