When running the text-based tl-setup, there are excessive line wrapping when printing the EULA, making it harder to read. See the following excerpt: > 8.1 The Program(s) is subject to laws and regulations of the > United > States and European Union that restrict its export. Licensee agrees > not > to export or "re-export" (transfer) the Program(s) unless all > applicable United States, European Union and other relevant government > export controls and approvals have been complied with. So what seems to be happening is that the on-disk EULA is limited to a certain number of columns while tl-setup tries to wrap it at another, smaller, number of columns, causing this excessive line wrapping.
This happens in both 4.13.0 and 4.14.0, so it's not a regression in the latest release.
We use Python's textwrap for the wrapping. It defaults to wrapping at 70 characters, and our EULA is written with the standard mail limit of 72 characters. Oddly enough the EULA has always been this width. And textwrap has also always defaulted to 70 characters. So no idea how we missed this in bug 3057.
This has now been fixed under the "trivial bug" umbrella.
I can confirm seeing this in 4.14.0. E.g.: > 8.8 Licensee shall not assign, transfer, or sublicense any > obligations or benefit under this License without the prior written > consent, which shall not be unreasonably withheld, of Cendio (and any > such attempt shall be void). Cendio may assign this License in whole > or > in part. In build 2521 I instead see: > 8.8 Licensee shall not assign, transfer, or sublicense any > obligations or benefit under this License without the prior written > consent, which shall not be unreasonably withheld, of Cendio (and any > such attempt shall be void). Cendio may assign this License in whole or > in part. So this now wraps correctly. And I didn't see any new issues in the rest of the text. Checking the code though, I'm wondering if we really need to special case just the EULA? Can't we have the same wrapping for everything?
Both tl-setup and tl-installer are now wrapped at 72 columns instead of 70. I did a fresh install on SLES12 and both of these look good with the slightly wider wrapping.
Checked the code changes and they look good. Also tested the wrapping on Ubuntu 20.04 for tl-installer, tl-setup and sudorelaunch, looks good.
