Bug 7839 - VSM server call can hang when verifying sessions
Summary: VSM server call can hang when verifying sessions
Status: NEW
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: VSM Server (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: LowPrio
Assignee: Bugzilla mail exporter
Depends on:
Reported: 2022-02-21 09:34 CET by Linn
Modified: 2023-03-03 13:09 CET (History)
0 users

See Also:
Acceptance Criteria:


Description Linn cendio 2022-02-21 09:34:09 CET
This was found when writing the session module for tlctl.

If we in the VSM server call specify that we want to verify the sessions but our filtering doesn't return any sessions (e.g. no sessions running or no matching username), VSM server will hang since we never call xmlrpc's handle_response().

We should add some handling for this corner case.
Comment 4 Pierre Ossman cendio 2022-03-10 11:25:05 CET
This can actually happen in practice with tlwebadm:

 * Open the details for a user, getting the URL https://example.com:1010/status/sessions?details=user1

 * Kill the session for that user

 * Refresh the page

This just stalls as you end up with the request in this here bug.
Comment 5 Linn cendio 2023-03-03 13:09:05 CET
I found one more scenario in webadmin where this hang can happen in the wild:

  1. Open the details for a user (same way as  in comment 4)

  2. Kill the session for the user, e.g. using tlctl.

  3. Click terminate session with the confirmation checkbox ticked.

  4. Notice the page being hanged.

Note You need to log in before you can comment on or make changes to this bug.