Bug 7835 - Source code for tlmisc-libs isn't in server bundle
Summary: Source code for tlmisc-libs isn't in server bundle
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Misc (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.15.0
Assignee: Tobias
URL:
Keywords: ossman_tester, prosaic
Depends on:
Blocks:
 
Reported: 2022-02-11 09:35 CET by Pierre Ossman
Modified: 2023-06-20 11:04 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:
Must ---- * Open source libs are shipped in server bundle sources


Attachments

Description Pierre Ossman cendio 2022-02-11 09:35:57 CET
We split tlmisc-libs off to be a more independent package in bug 5308, but we forgot to ship the new open source tar ball that this split created. There should have been a "thinlinc-tlmisc-libs-open-sources.tar.gz" in the "sources" directory.
Comment 2 Tobias cendio 2023-06-19 13:19:51 CEST
Tested building the server bundle in Fedora38. Build works fine and the missing open source libs tar is found in the server bundle sources.

Setting as resolved.
Comment 5 Tobias cendio 2023-06-19 15:00:35 CEST
Integrated the additional libs open source package into the previously existing open source tar ball, since for sake of symmetry we only want one source code package. Tested building on Fedora38 and the expected files are included.
Comment 6 Pierre Ossman cendio 2023-06-19 15:58:16 CEST
Compared the contents of 4.13.0, 4.14.0 and the current build, and it looks reasonable:

 * Between 4.13.0 and 4.14.0 we lost RequireJS (bug 7550), and cyclades-serial-client (this bug)

 * Between 4.14.0 and the current build we regained cyclades-serial-client, and we also got startupbg (bug 3054)

I have not checked the contents in detail, just the top-level directories. The size of the entire things, as well as the number of files, is also in the same magnitude for all three cases.
Comment 7 Pierre Ossman cendio 2023-06-20 11:04:06 CEST
Commit looks good, and the end result was tested above.

Note You need to log in before you can comment on or make changes to this bug.