Bug 7816 - ThinLinc Client options in "Security" and "Advanced" tabs are not logically grouped
Summary: ThinLinc Client options in "Security" and "Advanced" tabs are not logically g...
Status: NEW
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Client (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: MediumPrio
Assignee: Bugzilla mail exporter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-28 19:56 CET by Samuel Mannehed
Modified: 2022-01-28 15:52 CET (History)
0 users

See Also:
Acceptance Criteria:

Attachments
Client options with many tabs (22.81 KB, image/png)
2021-12-28 20:16 CET, Samuel Mannehed 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Description Samuel Mannehed cendio 2021-12-28 19:56:24 CET 
Currently, after the work done in bug 7522 and bug 6974 we have the following tabs in the client options:

* Display
* Local Devices
* Optimization
* Security
* Advanced

The two last tabs are generic and contain a mix of different options. The security tab contains options for:

* SSH Port
* Authentication Method

The SSH Port options don't really have anything to do with the auth method.

The advanced tab contains settings for:

* Start command
* Shadowing
* Popup menu key
* Emulate middle mouse button
* Send system keys
* Reconnect policy
* Software update check

This is just a big mix of things, a few themes can be found:

* Session type:
  - Start command
  - Shadowing
  - Reconnect policy
* Input:
  - Popup menu key
  - Emulate middle mouse button
  - Send system keys
Comment 1 Samuel Mannehed cendio 2021-12-28 20:16:14 CET 
Created attachment 1012 [details]
Client options with many tabs

A suggestion would be to split the security tab and the advanced tabs into 4 tabs:

* Authentication
  - Authentication method
* Input
  - Popup menu key
  - Emulate middle mouse button
  - Send system keys
* Connection
  - SSH Port
  - Reconnect policy
* Advanced
  - Shadowing
  - Start command
  - Software update check

Alternatively, the last two tabs above could make a big Advanced tab.

A problem with adding more tabs is that FLTK doesn't seem to have very graceful overflow handling of more tabs than what can fit, see the attached screenshot.

This was also discussed in comment #14 of bug 7522. We would need to add handling for this overflow somehow, especially considering that translations for many languages result in longer strings.
Comment 2 Pierre Ossman cendio 2022-01-12 09:58:16 CET 
(In reply to Samuel Mannehed from comment #1)
> 
> A problem with adding more tabs is that FLTK doesn't seem to have very
> graceful overflow handling of more tabs than what can fit, see the attached
> screenshot.
> 

We have shortened some strings in Russian even with the existing tabs to get everything to fit. When we can fix this issue we should try to go through the translations and allow the translators to go back to the most appropriate phrasings.
Comment 3 Samuel Mannehed cendio 2022-01-28 15:52:12 CET 
This upstream PR would make it possible to add more pages in a nice way:

https://github.com/TigerVNC/tigervnc/pull/1410
Note You need to log in before you can comment on or make changes to this bug.