Bug 7808 - Allow 10 users without licenses
Summary: Allow 10 users without licenses
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: License system (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.14.0
Assignee: Frida Flodin
URL:
Keywords: relnotes, samuel_tester
Depends on:
Blocks:
 
Reported: 2021-12-15 14:32 CET by Pierre Ossman
Modified: 2022-02-08 11:04 CET (History)
2 users (show)

See Also:
Acceptance Criteria:
* 10 concurrent users can use ThinLinc without a valid license. * When the 11th user tries to start a session it should be refused, the user gets a notification why, and information about this is found in vsmserver.log * No soft limit warning is printed in vsmserver.log when the 10th session is started. * More than 10 concurrent users can use ThinLinc with a valid license in /opt/thinlinc/etc/licenses

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Pierre Ossman cendio 2021-12-15 14:32:09 CET 
We want to promote more use of ThinLinc so we want to increase the number of users that can be had without paying for user licenses.

Right now we have a soft limit of 5 users, and a hard limit of 6 users. We want to change that to 10 users for both the soft and hard limit (i.e. there will be no grace usage for the free scenario).
Comment 1 Frida Flodin cendio 2021-12-17 08:29:40 CET 
Found some places on the webpage that need to be changed once the release is out:

- https://www.cendio.com/thinlinc/download
- Downloads page -> FAQ
- https://www.cendio.com/thinlinc/how-to-get-started
- https://www.cendio.com/thinlinc/buy
- https://www.cendio.com/thinlinc/support

There might be more pages with the old number of free licenses, I have not grepped in the source code.
Comment 5 Frida Flodin cendio 2021-12-17 10:54:29 CET 
I have tested this on Ubuntu 20.04 and everything seems to work just fine.



The acceptance criteria:

* 10 concurrent users can use ThinLinc without a valid license.
> Yes
* When the 11th user tries to start a session it should be refused, the user gets a notification why, and information about this is found in vsmserver.log
> Yes
* No soft limit warning is printed in vsmserver.log when the 10th session is started.
> No logging when the 10th session is started.
* More than 10 concurrent users can use ThinLinc with a valid license in /opt/thinlinc/etc/licenses
> A valid license works as before, and more than 10 users can start sessions.



Also tested the admin warning mail. No mail when 10 users connect, but with the
11th you get this in the mail:

> 2021-12-17 09:16 LICENSE VIOLATION: New session will exceed allowed use of
> 10 concurrent users. Hard limit of 10 concurrent users. 10 unique users
> currently running 10 sessions using 10 licenses

I checked the bug for the last time we changed this (bug 6194) and everything
from this bug should be reverted now. Except for the soft and hard limit being the same now.
Comment 6 Samuel Mannehed cendio 2021-12-21 10:23:22 CET 
The code changes and documentation look good. The acceptance criteria look mostly fine but missed to consider multiple sessions per user.

Using a server build (on Fedora 35) prior to this change I could see this in the vsmserver.log:

> 2021-12-20 14:54:08 INFO vsmserver.license: License summary: 5 concurrent users. Hard limit of 6 concurrent users.

And this in thinlinc-user-licenses:

> 2021-12-16 16:33 Valid user licenses: 5. 1 unique users currently running 1 sessions using 1 licenses

After the upgrade to server build 2378 I can now see, vsmserver.log:

> 2021-12-20 16:49:21 INFO vsmserver.license: License summary: 10 concurrent users. Hard limit of 10 concurrent users.

thinlinc-user-licenses:

> 2021-12-20 16:49 Valid user licenses: 10. 1 unique users currently running 1 sessions using 1 licenses

Using this I was successfully able to connect with 10 unique users, and the 11th user was denied login with this message in the client:

> ThinLinc login failed.
> (Cannot allocate license)

And this message in the vsmserver.log:

> 2021-12-21 09:28:42 WARNING vsmserver.license: LICENSE VIOLATION: Hit max number of concurrent users. Not allowing session for test11

When multiple sessions per user are enabled I could also login with an additional 9 sessions using one of the users. This is correct as long as these 10 sessions connect from the same client. When attempting to create a 10th additional session using this user I no longer got the option "New session" in the session selection window in the client. This is how it looks in thinlinc-user-licenses:

> 2021-12-21 09:28 Valid user licenses: 10. 10 unique users currently running 19 sessions using 10 licenses

After installing 50 valid licenses I was able to login with the 11th user. And this was written in vsmserver.log:

> 2021-12-21 09:44:27 INFO vsmserver.license: License summary: 50 concurrent users. Hard limit of 55 concurrent users.

And thinlinc-user-licenses:

> 2021-12-21 09:53 Valid user licenses: 50. 11 unique users currently running 20 sessions using 11 licenses

All works as expected, closing.
Comment 7 Samuel Mannehed cendio 2022-02-08 11:04:53 CET 
(In reply to Frida from comment #1)
> Found some places on the webpage that need to be changed once the release is
> out:
> 
> - https://www.cendio.com/thinlinc/download
> - Downloads page -> FAQ
> - https://www.cendio.com/thinlinc/how-to-get-started
> - https://www.cendio.com/thinlinc/buy
> - https://www.cendio.com/thinlinc/support
> 
> There might be more pages with the old number of free licenses, I have not
> grepped in the source code.

Our website has now also been updated to reflect this change.
Note You need to log in before you can comment on or make changes to this bug.