Bug 7803 - xdm ("-x") mode and "-f fullscreen" has random full-screen mode
Summary: xdm ("-x") mode and "-f fullscreen" has random full-screen mode
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Client (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.14.0
Assignee: Bugzilla mail exporter
URL:
Keywords: linma_tester, relnotes
Depends on:
Blocks: 7006
  Show dependency tree / graph
 
Reported: 2021-12-09 09:39 CET by Pierre Ossman
Modified: 2022-01-04 16:12 CET (History)
2 users (show)

See Also:
Acceptance Criteria:
• ☐ Using `-x' or `-f fullscreen' should result in full-screen mode being enabled over all monitors regardless of prior client configuration. • ☐ Using these flags should not cause any persistent change of the full-screen parameters in the client configuration. • ☐ When using these flags, the applied full-screen configuration should be represented visually in the "Display" tab under "Options". • ☐ When using the `-x' flag, the user should not be able to change the full-screen configuration graphically. • ☐ The documentation should make the exact behavior of these flags clear.

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Pierre Ossman cendio 2021-12-09 09:39:42 CET 
We've specified that when you start tlclient with "-x" or "-f fullscreen" then full screen will be forced on. However this code predates multi monitor support, and we never adjusted for that.

The end result is that it is not documented or well defined *which* full-screen mode you get. You'll get either over the current monitor, or over all of them, depending on the previously stored value of the FULL_SCREEN_ALL_MONITORS setting.

This is of course confusing and should be changed. Since the use case is dedicated terminals it seems reasonable to also force FULL_SCREEN_ALL_MONITORS with these flags.
Comment 1 Pierre Ossman cendio 2021-12-09 09:40:09 CET 
This is probably something we need to fix as part of bug 7006.
Comment 7 William Sjöblom cendio 2021-12-23 12:46:08 CET 
I have now verified the acceptance criteria using client build #2297 on Fedora 35.

• ☑ Using `-x' or `-f fullscreen' should result in full-screen mode
  being enabled over all monitors, regardless of prior client
  configuration.
• ☑ Using these flags should not cause any persistent change of the full
  screen parameters in the client configuration.
• ☑ When using these flags, the applied full-screen configuration should
  be represented visually in the "Display" tab under "Options".
• ☑ The documentation should make the exact behavior of these flags
  clear.

For the future tester, please note that XDM mode is restricted to Linux only. Marking as resolved!
Comment 9 Linn cendio 2022-01-04 16:11:31 CET 
Tested client build 2302 on Ubuntu 20.04, Windows 10 and macOS 12.1. As mentioned in comment 7, XDM mode is only applicable to Linux, so I did not test '-x' on Windows or Mac.


• Using `-x' or `-f fullscreen' should result in full-screen mode being enabled over all monitors regardless of prior client configuration.

  * It does.


• Using these flags should not cause any persistent change of the full-screen parameters in the client configuration.

  * Checked the parameters both before and after opening the client with '-x' and '-f fullscreen', works as intended.


• When using these flags, the applied full-screen configuration should be represented visually in the "Display" tab under "Options".

  * Yes, the GUI shows the correct configuration.


• When using the `-x' flag, the user should not be able to change the full-screen configuration graphically.

  * This is true for the options dialog before logging in. However, as reported in bug 7804, once inside the session, the user can change the fullscreen configuration graphically.


• The documentation should make the exact behavior of these flags clear.

  * The documentation is clear about what effect '-x' and '-f fullscreen' has.
Comment 10 Linn cendio 2022-01-04 16:12:34 CET 
Also checked the code and the relnotes, they both look good.
Note You need to log in before you can comment on or make changes to this bug.