Bug 7796 - Inconsistent use of fullscreen/full screen/full-screen
Summary: Inconsistent use of fullscreen/full screen/full-screen
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Other (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.14.0
Assignee: William Sjöblom
Keywords: ossman_tester, prosaic
Depends on:
Reported: 2021-11-17 16:05 CET by Pierre Ossman
Modified: 2022-12-01 15:41 CET (History)
2 users (show)

See Also:
Acceptance Criteria:


Description Pierre Ossman cendio 2021-11-17 16:05:05 CET
We are using various variations of fullscreen/full screen/full-screen and are even patching upstream TigerVNC between two variants. We should probably try to be consistent in our use.

So what is the proper way? Right now it seems like "full screen" for a noun, and "full-screen" as an adjective is the majority opinion, even if "fullscreen" is tolerated.


Comment 1 Pierre Ossman cendio 2021-11-17 16:07:15 CET
When fixing this we should probably also fix it upstream so we can avoid distracting diffs.
Comment 2 William Sjöblom cendio 2021-11-24 10:22:24 CET
I've done some looking around too and have come to the same conclusions as in comment 0. So let's go ahead and stick to the following conventions:

• "full-screen" when referring to the adjective/mode
• "full screen" when referring to the noun
Comment 3 William Sjöblom cendio 2021-11-24 13:04:15 CET
A pull request has been submitted that address these issues in upstream TigerVNC: https://github.com/TigerVNC/tigervnc/pull/1382
Comment 7 William Sjöblom cendio 2021-11-24 17:30:11 CET
TigerVNC, noVNC, the documentation, and tlclient have now all been updated to use the conventions in comment 2 and all changes to the former two have been upstreamed. Worth noting is that I didn't bother updating our downstream version of noVNC since we've disabled the full-screen features in WebAccess.  

Grepping for "screen" in the `ctc/' tree no longer result in any incorrect full.*screen hits.

Regarding release notes, I did some grepping around in our old release notes and couldn't find any release notes on changes with the same theme as this one. If there are any objections to this bug being marked prosaic, feel free to reopen it.
Comment 8 William Sjöblom cendio 2021-11-24 17:35:26 CET
Also, a note on testing:

Be aware that the words "full screen" can span multiple lines and may have other characters in between:

>  char *some_string = "full\n"
>                      "screen";

So make sure to put some extra love into your regexps!
Comment 9 William Sjöblom cendio 2021-11-25 12:52:39 CET
Apparently, there are a couple of screenshots that need updating as well
Comment 11 William Sjöblom cendio 2021-11-25 17:20:03 CET
The screenshots have now been updated!
Comment 12 Pierre Ossman cendio 2021-11-26 11:36:29 CET
Tried to find things that were still wrong. Found lots of variable names and comments, but I guess it's not worth the effort to change those. We also have stuff like configuration values that cannot be changed for backward compatibility reasons. And as mentioned, Web Access still has some incorrect uses that aren't visible in ThinLinc.

However I found this in the documentation:

> doc/external/client_options_screen.rst:   you run in full screen mode and want to reach the native session that

(used pcregrep -M to catch any occurences split over two lines as well)

Screenshots look good.
Comment 14 William Sjöblom cendio 2021-11-26 11:44:02 CET
The issue mentioned in comment 12 has now been corrected.
Comment 15 Pierre Ossman cendio 2021-11-26 13:08:49 CET
Looks good now.

I also checked the commits and everything looked correct there.

Note You need to log in before you can comment on or make changes to this bug.