Bug 7780 - tl-config -a no longer lists folders
Summary: tl-config -a no longer lists folders
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Misc (show other bugs)
Target Milestone: 4.15.0
Assignee: Samuel Mannehed
Keywords: linma_tester, ossman_tester, relnotes
Depends on:
Reported: 2021-10-26 10:36 CEST by Pierre Ossman
Modified: 2022-04-14 11:03 CEST (History)
2 users (show)

See Also:
Acceptance Criteria:


Description Pierre Ossman cendio 2021-10-26 10:36:38 CEST
ThinLinc 4.13.0 unfortunately has a regression in the tl-config tool. In 4.12.1 you can do:

> $ /opt/thinlinc/bin/tl-config -a /
> shadowing/ 
> utils/ 
> vsmagent/ 
> profiles/ 
> printing/ 
> vsmserver/ 
> webaccess/ 
> sessionstart/ 
> vsm/ 

However in 4.13.0 you get nothing:

> $ /opt/thinlinc/bin/tl-config -a /

This makes it a bit more difficult to explore the configuration tree.

This is likely a regression from bug 7557.
Comment 1 Samuel Mannehed cendio 2021-10-26 11:04:42 CEST
This is a regression from commit r37283, hivetool from before that change will print folders like listed above.
Comment 2 Samuel Mannehed cendio 2022-04-08 15:53:39 CEST
Note that "tl-config -R -a /" works, but that gives you a full tree which isn't very useful most of the time.
Comment 4 Samuel Mannehed cendio 2022-04-08 18:57:42 CEST
This is fixed now. The issue was that sub-folder names were only printed when hivetool was used recursively.
Comment 6 Linn cendio 2022-04-11 13:48:28 CEST
Tested with server build 2567 on Fedora 35, and can confirm that the fix works.

When running without recursion the folders are correctly printed, and when running with recursion the print works like before the fix.
> $ /opt/thinlinc/bin/tl-config -a /
> $ /opt/thinlinc/bin/tl-config -R -a /
The changed code only runs when flag '-a' is included, so I deemed these tests enough. I also looked through the code changes as well as the release notes, both look good. Closing!
Comment 9 Samuel Mannehed cendio 2022-04-13 10:35:17 CEST
Two minor changes were added, moving back from CLOSED to RESOLVED.
Comment 11 Pierre Ossman cendio 2022-04-14 11:03:48 CEST
Re-tested. Looks good and correct for all combinations of -R and -a.

Note You need to log in before you can comment on or make changes to this bug.