Bug 7769 - Show and hide on macOS don't work once connected
Summary: Show and hide on macOS don't work once connected
Status: NEW
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Client (show other bugs)
Target Milestone: LowPrio
Assignee: Bugzilla mail exporter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-22 14:22 CEST by Pierre Ossman
Modified: 2021-09-28 10:06 CEST (History)
0 users

See Also:
Acceptance Criteria:


Attachments

Description Pierre Ossman cendio 2021-09-22 14:22:23 CEST
On macOS you can right click on the icon in the dock and select "Hide" or "Show", depending on the current state of the application. This works in ThinLinc as long as the tlclient UI is still up, but not once vncviewer is shown.

We have code that delegates these events to vncviewer, but it is no longer working. After some tracing I can see that we get procNotFound when calling ShowHideProcess().

I'm guessing that this functionality has simply been removed from macOS at some point. The Carbon API was deprecated in macOS 10.8, and it seems process serial number arguments were removed in macOS 10.9. So any API using those is probably a bit hit-and-miss now.

Oddly enough GetProcessForPID() still works and gives us something that looks sane.

This code was last touched on bug 4368 and tested on macOS 10.8. It is unlikely it has been tested since.

Note You need to log in before you can comment on or make changes to this bug.