Bug 7750 - macOS main menu isn't properly translated
Summary: macOS main menu isn't properly translated
Status: NEW
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Client (show other bugs)
Target Milestone: LowPrio
Assignee: Bugzilla mail exporter
Depends on:
Reported: 2021-08-24 16:50 CEST by Pierre Ossman
Modified: 2021-11-17 16:28 CET (History)
0 users

See Also:
Acceptance Criteria:

Screenshot of English menu on Swedish system (213.15 KB, image/png)
2021-08-24 16:50 CEST, Pierre Ossman
Properly translated menu for Finder (223.96 KB, image/png)
2021-08-25 13:55 CEST, Pierre Ossman

Description Pierre Ossman cendio 2021-08-24 16:50:39 CEST
Created attachment 989 [details]
Screenshot of English menu on Swedish system

The standard portion of the macOS main menu for ThinLinc client isn't translated and will always be displayed in English. This gives a bit of a bad impression since this menu is usually translated in macOS, and we also translate the "File" menu we add next to it.

Oddly enough the system doesn't provide translations for this, even though every application is expected to have the same entries. If you create a new project in Xcode you only get English and you have to provide every translation manually. So it seems we have to go this route as well.

(The services submenu is provided by the system, and this seems to be properly translated for us at least)

FLTK includes translations for this as part of their Xcode resources, but I'm not sure how this is supposed to be used when FLTK is bundled and/or statically linked.
Comment 1 Pierre Ossman cendio 2021-08-24 17:01:55 CEST
Also note that if you press Option then "Quit ThinLinc-klient" switches to "Avsluta och bibehåll fönster" (Swedish for "Quit and keep windows), i.e. it gets translated.

I suspect this is some magic done by the system for any entry that has "terminate:" as the action.
Comment 2 Pierre Ossman cendio 2021-08-25 13:51:52 CEST
This seems to be a regression as we have code that is supposed to handle this. It is also not a recent regression as even ThinLinc 4.9.0 has this issue. The code was originally written for ThinLinc 3.2.0, and last touched in bug 3865 for ThinLinc 3.3.0. So this might have been broken for years.
Comment 3 Pierre Ossman cendio 2021-08-25 13:55:33 CEST
Created attachment 994 [details]
Properly translated menu for Finder

Note You need to log in before you can comment on or make changes to this bug.