Bug 7744 - tl-setup doesn't handle failed installed correctly in text mode
Summary: tl-setup doesn't handle failed installed correctly in text mode
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Server Installer (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.13.0
Assignee: Pierre Ossman
URL:
Keywords: prosaic, wilsj_tester
Depends on:
Blocks:
 
Reported: 2021-07-15 11:04 CEST by Pierre Ossman
Modified: 2021-08-09 10:18 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Pierre Ossman cendio 2021-07-15 11:04:47 CEST 
The handling of a failed package installed in text mode is currently completely backwards in tl-setup. It refuses to continue for optional packages, and gladly proceeds for non-optional packages. This should of course be the other way around.

This bug has been around since the beginning as far as I can tell.
Comment 2 Pierre Ossman cendio 2021-07-20 13:07:34 CEST 
Fixed now.
Comment 3 William Sjöblom cendio 2021-08-09 10:18:00 CEST 
Tested on a Fedora 34 machine without Python ldap installed.

This was done by writing a `sys.exit(1)` to /opt/thinlinc/libexec/dnfhelper after the resolve step when tl-setup installs Python ldap.

- 4.12.1: tl-setup exits even though the package is optional.
- Jenkins server build #2244: tl-setup lets us continue without ldap.

Marking as closed.
Note You need to log in before you can comment on or make changes to this bug.