Bug 7727 - tl-notify requires Python 2
Summary: tl-notify requires Python 2
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Misc (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.13.0
Assignee: Niko Lehto
URL:
Keywords: ossman_tester, prosaic
Depends on:
Blocks: 4586
  Show dependency tree / graph
 
Reported: 2021-06-18 12:40 CEST by Niko Lehto
Modified: 2021-07-14 09:31 CEST (History)
0 users

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Niko Lehto cendio 2021-06-18 12:40:48 CEST 
Our tl-notify still requires Python 2 and should be converted to support Python 3.
Comment 6 Niko Lehto cendio 2021-06-23 15:04:01 CEST 
Tested on Fedora 33 server with build containing the changes. Tested the following:

✔ Send notification to specified user with "-u cendio"
✔ Send notification to specified user with "--user cendio"

✔ Send notification to all users with "-u all"
✔ Send notification to all users as default (only msg given)

✔ Warning if given user has no session
✔ Warning if the agent does not have any sessions
✔ Error if given user not found
✔ Error if no message given
Comment 7 Pierre Ossman cendio 2021-06-24 14:57:30 CEST 
Tested on RHEL 8:

 * Sessions starting up (gives error, but doesn't crash)
 * All users
 * Multiple lines
 * Non-ASCII
 * Specific user
 * Invalid user
 * User without sessions
 * To all when there are no sessions

Seems to work just fine.
Note You need to log in before you can comment on or make changes to this bug.