Bug 7724 - We are out of sync with upstream rpmvercmp
Summary: We are out of sync with upstream rpmvercmp
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Server Installer (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.13.0
Assignee: William Sjöblom
Keywords: frifl_tester, prosaic
Depends on:
Reported: 2021-06-09 17:11 CEST by William Sjöblom
Modified: 2021-06-11 14:56 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:


Description William Sjöblom cendio 2021-06-09 17:11:22 CEST
We roll our own python port of rpmvercmp.c from librpm for comparing rpm package versions. This port has not been synchronized with upstream since 2012. We should update our port to reflect the behavior of current librpm versions.
Comment 2 William Sjöblom cendio 2021-06-10 12:20:56 CEST
rpmvercmp and its unit tests have now been updated to reflect the latest upstream stable librpm (

Upgrading from 4.12.1 to a development build still works as intended on Fedora 33. Rerunning the development build installer with the development build already installed results in "The system already has an up to date installation of ThinLinc".

Testing can be done using by upgrading a couple of older server releases to a development build. Preferably using an older rpm distribution such as RHEL7.

Marking as resolved.
Comment 3 Frida cendio 2021-06-11 14:56:34 CEST
Looks good and works as expected. Tested on RHEL 7:

   Installed             Trying to install      Result
   4.9.0-5775       -->  4.12.1post-2135        Upgraded

   4.12.1post-2135  -->  4.12.1post-2135        Already up to date

   4.12.1post-2135  -->  4.12.1post-2134        Already up to date*

   4.12.1-6733      -->  4.12.1post-2135        Upgraded

* Build 2134 also have the changes for this bug, so this tests that nothing happens when trying to downgrade. This is expected behavior.

Note You need to log in before you can comment on or make changes to this bug.