Bug 7678 - Broken behaviour for ss - limited to updating only one session status at a time
Summary: Broken behaviour for ss - limited to updating only one session status at a time
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: VSM Server (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.13.0
Assignee: Linn
URL:
Keywords: prosaic, samuel_tester
Depends on:
Blocks:
 
Reported: 2021-04-08 13:54 CEST by Linn
Modified: 2021-04-13 11:40 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Linn cendio 2021-04-08 13:54:29 CEST 
With the current implementation, only one of the sessions would be marked as 'unreachable' in the sessionstore on a startup issue or decode error, no matter how many sessions that actually are unreachable.

We should fix so that all sessions that are unreachable show as such.
Comment 1 Linn cendio 2021-04-08 16:55:15 CEST 
As a clarification, this behaviour is seen when ThinLinc runs 'ss' to check the status of its sessions. 

This is noticed by only marking one of the unreachable sessions as unreachable, and the wanted behaviour is that all unreachable sessions should be marked as such.
Comment 3 Linn cendio 2021-04-12 11:38:48 CEST 
Tested with build 1997 and it seems to be working. The periodic log updates now marks the status as unreachable for all those sessions at once.

Tips for tester:
 * You can break ss by replacing it with your own script
 * Set session_update_delay in vsmserver.hconf to shorten the waiting time between each update
Comment 4 Samuel Mannehed cendio 2021-04-13 11:40:59 CEST 
I verified the problem using build 1995 on Fedora 33 by replacing the ss binary.

This bug only concerns the periodic updates. If viewing the sessions from the Web Admin interface all sessions was marked as unreachable even prior to the fix. That is because in this case the sessions are checked individually.

I did see however that the vsmserver.log only posted one log line for one of the unreachable sessions, not all when doing it's periodic check on the 10 minute interval.

Upgrading to build 2002 shows that the problem is fixed. The code change also looks good.
Note You need to log in before you can comment on or make changes to this bug.