Bug 7675 - XML-RPC errors aren't reported to caller
Summary: XML-RPC errors aren't reported to caller
Status: NEW
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Other (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: MediumPrio
Assignee: Bugzilla mail exporter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-07 16:18 CEST by Pierre Ossman
Modified: 2021-06-08 13:18 CEST (History)
0 users

See Also:
Acceptance Criteria:


Attachments

Description Pierre Ossman cendio 2021-04-07 16:18:02 CEST
If we have any kind of XML-RPC error then we just close the connection. We should be responding at the very least with a HTTP error code, and likely also with a XML-RPC Fault response.

This should be done with errors with regard to the XML-RPC request itself (e.g. bug 5032), and when the handler crashes.

One problem we get by not doing this is that the default behaviour of Python's XML-RPC client is to repeat the request, so we get a double crash in our logs.

Note You need to log in before you can comment on or make changes to this bug.