If the client encounters some error handling XML-RPC requests then it will present the user with the error: > ThinLinc login failed. > (The SSH connection succeeded, but the ThinLinc server connection failed. > Perhaps this server doesn't run a ThinLinc server? Which isn't really true as we are now at a point where we know we are talking to a ThinLinc system. This is what's seen in the client log at this point: > 2021-03-26T12:22:00: ssh[E]: THINLINC-LOGIN: HELLO 4.12.1post > 2021-03-26T12:22:00: ssh[E]: THINLINC-LOGIN: CONNECTED MASTER > 2021-03-26T12:22:00: My hardware address is 00D861420289 > 2021-03-26T12:22:00: Calling XML-RPC method 'get_capabilities' The issue was seen when thinlinc-login had a bug that caused it to crash after getting the request.
It is worth noting that this error message is identical to the one we get when the master login fails. It looks like this message is a remnant from before we had thinlinc-login and the XML-RPC call was the most logical place to catch this type of error.
Attachment 1171 [details] on bug 8261 fixes this bug.
Applied Attachment 1171 [details] and verified on Fedora 38, Windows 10, and macOS 14.1.1 that the error message has been changed to > ThinLinc login failed. > (Error in communication between client and server.) I could also see the new log message in the log when this happens: > 2024-01-04T10:06:26: Calling XML-RPC method 'get_capabilities' > 2024-01-04T10:06:26: Call to XML-RPC method 'get_capabilities' failed MUST: * The error message from a failed XML-RPC call is not misleading ✅ EXTRA: * The error message from a failed XML-RPC call is logged and understandable ✅ Closing.
