Bug 7633 - Silencing EPIPE/ECONNRESET errors in httpserver hides other problems
Summary: Silencing EPIPE/ECONNRESET errors in httpserver hides other problems
Status: NEW
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Misc (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: MediumPrio
Assignee: Bugzilla mail exporter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-28 11:24 CET by Pierre Ossman
Modified: 2021-03-09 14:41 CET (History)
0 users

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Pierre Ossman cendio 2021-01-28 11:24:09 CET 
We ignore EPIPE and ECONNRESET when handling requests in thinlinc.httpserver. HTTPSRequestHandler as a browser might decide do abandon a connection and just close it. We don't want nasty log messages for this common scenario, hence why we just silently drop things.

However we don't actually make sure it's just for that scenario. So we end up ignoring EPIPE and ECONNRESET from every possible source. A handler might be making other connections that we want to see when they fail.

This has been observed for the VNC socket in tlwebaccess on bug 7552 where we got nothing in the logs despite socket problems.
Comment 1 Pierre Ossman cendio 2021-01-28 11:25:42 CET 
To fix this we can either make sure we somehow only trigger on writes to the browser. Or we can consider even that a bug and fix up all calls that send things to the browser to handle this scenario.
Note You need to log in before you can comment on or make changes to this bug.