Bug 7563 - Clipboard broken when using an old client and using ISO 8859-1
Summary: Clipboard broken when using an old client and using ISO 8859-1
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: VNC (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.12.1
Assignee: Niko Lehto
URL:
Keywords: frifl_tester, relnotes
Depends on:
Blocks:
 
Reported: 2020-10-02 14:56 CEST by Pierre Ossman
Modified: 2021-01-21 12:45 CET (History)
2 users (show)

See Also:
Acceptance Criteria:


Attachments

Description Pierre Ossman cendio 2020-10-02 14:56:54 CEST
Clipboard handling when using olders clients is utterly broken when trying to transfer ISO 8859-1, likely because of bug 3895.

It is broken in both directions, but in different ways:

Copying from the server to the client results in extra "?" after each non-ASCII character.

Copying from the client to the server results in every non-ASCII character getting replaced with � (U+FFFD).


It is likely the combination new client/old server is also broken as the same conversion routines are involved.
Comment 1 Pierre Ossman cendio 2020-10-02 15:31:45 CEST
Upstream issue:

https://github.com/TigerVNC/tigervnc/issues/1119
Comment 2 Pierre Ossman cendio 2020-10-05 16:53:38 CEST
Fixed upstream:

https://github.com/TigerVNC/tigervnc/pull/1120

So we just need to do a vendor drop to get this in.
Comment 8 Niko Lehto cendio 2020-12-23 17:31:35 CET
We will do a smaller release x.x.1 one, so we don't want to take in too much with a vendor drop. This issue is fixed upstream.
Patched this for now.

Testing 7563:
RHEL8 server and client.

Reproduced on:

|Client version | Server version | Reproduced?
+---------------+----------------+-----------+
|4.11.0         | Nightly        | Yes       |
+---------------+----------------+-----------+
|Nightly        | 4.11.0         | Yes       |
+--------------------------------------------+

After client and server rebuild with the patch, I tested
the same combination again:

|Client version | Server version | Working?
+---------------+----------------+-----------+
|4.11.0         | Fixed          | Yes       |
+---------------+----------------+-----------+
|Fixed          | 4.11.0         | Yes       |
+--------------------------------------------+
|Fixed          | Fixed          | Yes       |
+--------------------------------------------+
Comment 11 Niko Lehto cendio 2021-01-04 09:25:07 CET
Also tested that Webaccess still works well with server containing the fixes.
Comment 12 Frida Flodin cendio 2021-01-04 15:37:16 CET
I can verify that this issue has been fixed. I could reproduce on:

| Client | Server | Reproduced? |
|--------+--------+-------------|
|   4.11 |   4.12 | Yes         |
|   4.12 |   4.11 | Yes         |


And verified that everything works fine on:

| Client         | Server         | Works fine? |
|----------------+----------------+-------------|
| 4.11           | Nightly (6707) | Yes         |
| Nightly (6707) | 4.11           | Yes         |
| 4.12           | Nightly (6707) | Yes         |
| Webaccess      | Nightly (6707) | Yes         |


The testing was performed on the following systems:

| Component      | System                 |
|----------------+------------------------|
| 4.11 Client    | Ubuntu 16.04           |
| 4.12 Client    | Ubuntu 16.04           |
| Nightly Client | Fedora 32              |
| 4.11 Server    | Ubuntu 18.04           |
| 4.12 Server    | Ubuntu 18.04           |
| Nightly Server | Ubuntu 18.04 and 20.04 |
| Webaccess      | Chrome 87 on Fedora 32 |

Also looked at the release note, looks good. Closing!
Comment 13 Niko Lehto cendio 2021-01-18 17:04:04 CET
I encountered error where copying "åäö" INTO the client will result in "\u00e5\u00e4\u00f6". Copying "åäö" from the client works fine though.

This happens with:
  Client: 4.12.0 on Fedora 31
  Server: Nightly (6721) on RHEL 8
Comment 14 Niko Lehto cendio 2021-01-20 10:37:03 CET
(In reply to Niko Lehto from comment #13)
This is an issue not connected to this bug. Filed a new bug for it, see Bug 7627. Closing again.

Note You need to log in before you can comment on or make changes to this bug.