Bug 7553 - Cheetah requires Python 2
Summary: Cheetah requires Python 2
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Web Administration (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.13.0
Assignee: Linn
Keywords: ossman_tester, prosaic
Depends on:
Blocks: 4586 7552 7554
  Show dependency treegraph
Reported: 2020-09-09 16:14 CEST by Linn
Modified: 2021-03-25 13:41 CET (History)
2 users (show)

See Also:
Acceptance Criteria:


Description Linn cendio 2020-09-09 16:14:33 CEST
Cheetah is getting old and is not built for Python 3, so we should look into alternative solutions.
Comment 1 Linn cendio 2020-09-10 10:47:45 CEST
* Official cheetah web page (https://cheetahtemplate.org/) now points to Cheetah3 instead of Cheetah. This make it seem like Cheetah3 is the new official version.

* In an issue discussing compatibility between Cheetah and Cheetah3, the aim of Cheetah3 is to make Cheetah templates Python 3 compatible.

* We did a drop in replacement on an installed ThinLinc server replacing our old Cheetah with Cheetah3. Everything seems to work.
Comment 2 Samuel Mannehed cendio 2020-09-10 12:29:58 CEST
Note bug 4245, we should probably fix the Cheetah part of that while doing this bug.
Comment 5 Linn cendio 2020-09-11 14:16:06 CEST
(In reply to Samuel Mannehed from comment #2)
> Note bug 4245, we should probably fix the Cheetah part of that while doing
> this bug.

After some investigation we will not do this until the entire Python 3 conversion. See bug 4245
Comment 6 Frida cendio 2020-09-14 11:17:38 CEST
* Cheetah3 works for both Python 2 and 3
* We have done tests on running Web Administration and Web Access with the new Cheetah3 and Python 2
* Everything seems to work fine so the new Cheetah3 is used instead of the old from now on.
Comment 7 Pierre Ossman cendio 2020-09-16 16:26:22 CEST
Functionality seems to be working fine. I tested various dynamic things in webaccess (error messages, logins) and many different pages of tlwebadm that are using lots of macros. Could not spot any issues.

Commit also looks fine, except for the fact that the license for Cheetah has been updated a bit.
Comment 9 Samuel Mannehed cendio 2020-09-17 10:56:13 CEST
The open source licenses in docs have now been updated with the new Cheetah license.
Comment 10 Pierre Ossman cendio 2020-09-21 09:22:38 CEST
Looks good now. Verified that the new license is included in the server bundle.

Note You need to log in before you can comment on or make changes to this bug.