Bug 7528 - tl-setup fails if no tlwebadm password is configured
Summary: tl-setup fails if no tlwebadm password is configured
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Server Installer (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.12.1
Assignee: Niko Lehto
Keywords: linma_tester, ossman_tester, relnotes
Depends on:
Blocks: 5117
  Show dependency treegraph
Reported: 2020-06-30 11:26 CEST by Pierre Ossman
Modified: 2021-01-21 12:45 CET (History)
3 users (show)

See Also:
Acceptance Criteria:


Description Pierre Ossman cendio 2020-06-30 11:26:31 CEST
Now that we've switched to systemd units (bug 4290), we apparently got the side effect that you are forced to enter a password for tlwebadm. If you don't then tl-setup will fail to start the services:

> 2020-06-30 11:19:14,344: Starting service 'tlwebadm'...
> 2020-06-30 11:19:14,865: Output (stderr):
> 2020-06-30 11:19:14,866:     Job for tlwebadm.service failed because the service did not take the steps required by its unit configuration.
> 2020-06-30 11:19:14,866:     See "systemctl status tlwebadm.service" and "journalctl -xe" for details.
> 2020-06-30 11:19:14,866: Failed to start service 'tlwebadm'
> 2020-06-30 11:19:22,509: tl-setup is finished

systemd is upset the service never really got going properly:

> [root@dhcp-254-219 ~]# systemctl status tlwebadm
> ● tlwebadm.service - ThinLinc Web Administration
>    Loaded: loaded (/usr/lib/systemd/system/tlwebadm.service; enabled; vendor preset: disabled)
>    Active: failed (Result: protocol) since Tue 2020-06-30 11:19:14 CEST; 54s ago
>   Process: 3934 ExecStart=/bin/bash --login -c /opt/thinlinc/sbin/tlwebadm (code=exited, status=0/SUCCESS)
> Jun 30 11:19:14 dhcp-254-219.lkpg.cendio.se systemd[1]: Starting ThinLinc Web Administration...
> Jun 30 11:19:14 dhcp-254-219.lkpg.cendio.se systemd[1]: tlwebadm.service: Can't open PID file /var/run/tlwebadm.pid (yet?) after start: No such file or > directory
> Jun 30 11:19:14 dhcp-254-219.lkpg.cendio.se systemd[1]: tlwebadm.service: Failed with result 'protocol'.
> Jun 30 11:19:14 dhcp-254-219.lkpg.cendio.se systemd[1]: Failed to start ThinLinc Web Administration.

Which of course is because there is no password:

> 2020-06-30 11:19:14 ERROR tlwebadm[3953]: No password configured. Exiting.
Comment 3 Niko Lehto cendio 2021-01-12 10:49:56 CET
Tested on RHEL8 server. Could reproduce the issue with nightly build.

I tested tl-setup with and without password given.
Now the webadmin page can be accessed if a password is given and tl-setup will not fail if no password were given.
Comment 4 Pierre Ossman cendio 2021-01-12 15:36:08 CET
The service now gladly starts without a password configured (regressing bug 3880). So this isn't quite what we want. It's the fact that tl-setup gets upset about this predictable scenario that's the issue.
Comment 7 Niko Lehto cendio 2021-01-14 09:13:58 CET
Reverted the changes done in r35961. And re-tested after the latest fix.

Tested text installer on RHEL8 and the graphical installer on Ubuntu 18.04.
Checked that services were started correctly and that webadmin plattform worked when password were given.

 - With password
 - Without password

 - With password
 - Without password

Also revised the release notes made in r35961.
Comment 8 Linn cendio 2021-01-15 14:00:07 CET
I tested the text installer on Ubuntu 20.04 and the GUI installer on Fedora 32, and it works as expected and gives appropriate log messages. The release notes also look good.

 GUI | Text
  ✓     ✓   With password
  ✓     ✓   Without password

Note You need to log in before you can comment on or make changes to this bug.