Bug 7509 - thinlocal and nearest can't be configured with modern cups
Summary: thinlocal and nearest can't be configured with modern cups
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Printing (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.12.0
Assignee: Bugzilla mail exporter
Keywords: relnotes
Depends on:
Reported: 2020-06-01 14:00 CEST by Samuel Mannehed
Modified: 2020-06-22 11:23 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:


Description Samuel Mannehed cendio 2020-06-01 14:00:56 CEST
When tl-setup tries to configure our printer queues on Fedora 32 it fails. The log says:

2020-06-01 13:55:13,615: Configuring CUPS...
2020-06-01 13:55:13,616: Adding 'nearest' printer queue...
2020-06-01 13:55:13,643: Failed to run printer script '/opt/thinlinc/libexec/add_nearest_printer.sh'
2020-06-01 13:55:13,643: Output (stdout):
2020-06-01 13:55:13,643:     Using CUPS installed at prefix /usr
2020-06-01 13:55:13,644:     Using CUPS_SERVERBIN=/usr/lib/cups
2020-06-01 13:55:13,644:     Error: Cannot find required command /usr/sbin/accept.

It seems this command has been renamed to "/usr/sbin/cupsaccept" in new versions of cups.
Comment 2 Pierre Ossman cendio 2020-06-04 11:30:40 CEST
Also happens with Ubuntu 20.04, so the issue seems to be cups 2.3+.
Comment 3 Alex Tanskanen cendio 2020-06-18 10:26:46 CEST
I applied the patch for this fix and ran tl-setup on Ubuntu 16.04/20.04 and RHEL 7/8. Tl-setup finishes without any problem. I didn't actually try printing but I checked the web admin page and both nearest and thinlocal showed up.
Comment 5 Pierre Ossman cendio 2020-06-18 13:58:56 CEST
Do we really need to support the old "accept" and "enable"? Can't we simplify things now?
Comment 6 Pierre Ossman cendio 2020-06-22 09:58:52 CEST
I checked the old distributions, and even RHEL 6 and Ubuntu 12.04 has cupsenable/cupsaccept. So it should be safe to drop the code supporting even older stuff.
Comment 8 Pierre Ossman cendio 2020-06-22 11:22:33 CEST
Old code dropped.
Comment 9 Pierre Ossman cendio 2020-06-22 11:23:05 CEST
Tested thinlocal on Ubuntu 16.04, 20.04 and RHEL 7. Worked fine on all three.

Note You need to log in before you can comment on or make changes to this bug.