When tl-setup tries to configure our printer queues on Fedora 32 it fails. The log says:
2020-06-01 13:55:13,615: Configuring CUPS...
2020-06-01 13:55:13,616: Adding 'nearest' printer queue...
2020-06-01 13:55:13,643: Failed to run printer script '/opt/thinlinc/libexec/add_nearest_printer.sh'
2020-06-01 13:55:13,643: Output (stdout):
2020-06-01 13:55:13,643: Using CUPS installed at prefix /usr
2020-06-01 13:55:13,644: Using CUPS_SERVERBIN=/usr/lib/cups
2020-06-01 13:55:13,644: Error: Cannot find required command /usr/sbin/accept.
It seems this command has been renamed to "/usr/sbin/cupsaccept" in new versions of cups.
Also happens with Ubuntu 20.04, so the issue seems to be cups 2.3+.
I applied the patch for this fix and ran tl-setup on Ubuntu 16.04/20.04 and RHEL 7/8. Tl-setup finishes without any problem. I didn't actually try printing but I checked the web admin page and both nearest and thinlocal showed up.
Do we really need to support the old "accept" and "enable"? Can't we simplify things now?
I checked the old distributions, and even RHEL 6 and Ubuntu 12.04 has cupsenable/cupsaccept. So it should be safe to drop the code supporting even older stuff.
Old code dropped.
Tested thinlocal on Ubuntu 16.04, 20.04 and RHEL 7. Worked fine on all three.