Bug 7499 - Crash when calling SCardStatus() with NULL parameters
Summary: Crash when calling SCardStatus() with NULL parameters
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Smart card (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.12.0
Assignee: Pierre Ossman
URL:
Keywords: relnotes, samuel_tester
Depends on:
Blocks:
 
Reported: 2020-05-14 11:40 CEST by Pierre Ossman
Modified: 2020-06-02 15:54 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Pierre Ossman cendio 2020-05-14 11:40:22 CEST 
The API documentation for SCardStatus() does not state that it is valid to specify NULL for pdwState or pdwProtocol, however some applications seem to do this anyway.

It is tolerated without errors in pcsc-lite, so we probably need to follow suit. We have not checked how Windows behaves.
Comment 2 Pierre Ossman cendio 2020-05-14 11:40:51 CEST 
Should probably check the other calls for similar issues.
Comment 5 Pierre Ossman cendio 2020-05-18 11:17:17 CEST 
Should be fixed now. Unfortunately we don't have the software to reproduce the crash here so a code review or synthetic test case will have to do.
Comment 6 Samuel Mannehed cendio 2020-06-02 15:54:06 CEST 
Code looks good. Smart card tunneling still works, tested with ThinLinc server build 6492.r35050.
Note You need to log in before you can comment on or make changes to this bug.