Since the latest ImageMagick upgrade in cenbuild the images in ctc/client/tlclient/icons are no longer correctly created. The issue seems to lie with the way SVG image sizes are handled. The problem is that the ThinLinc logo becomes the wrong size for many icons. Most notibly in the tlclient_heading where the logo doesn't even fit the image. A difference in behavior can be observed between ImageMagick 6.9 from Fedora vs the ImageMagick 7.0 in cenbuild. It's a fuzzy area and it's not clear which version is behaving correctly. The gist seems to be that we have to explicitly state the intended size of the SVG we want to use in the ImageMagick scripts.
Another issue with these ImageMagick scripts is that the tlclient_symbolic icons are generated completely empty. They should contain a black-and-white thinlinc icon.
Fortunately, the incorrect icons never made it to the user product since we don't rebuild these every time. The old icons were checked in to subversion.
All fixed now. Generating new icons works well now with the new ImageMagick in our build system, and newly generated ones have been committed. The result is not EXACTLY the same as before, but if anything it looks better now. The new icons look a tiny bit sharper than before.
The modified images are used in a number of places: * ThinLinc Setup desktop shortcut icon * Profile Chooser footer icon * Header in tlclient login window * Client desktop shortcut icon (different size used on macOS) * Client icon for HP ThinPro connection wizard * Client icon for thinstation packaging * Web Administration Interface desktop shortcut icon * Web Administration Interface favicon * Web Administration Interface header icon * Web Administration Interface large icon on page 'Main/Home' * Web Administration Interface system icons on page 'Status/Load' * Web Access desktop shortcut icon * Web Access login page favicon * Web Access redirect page favicon * Web Access connected (noVNC) favicon * Web Access iOS add-to-homescreen icon * Web Access Chrome add-to-homescreen icon * Web Access Firefox add-to-homescreen icon * GNOME 3 symbolic top bar icon for all ThinLinc programs * Sample login form icons in tlclient.cgi
Verified that the images mentioned in comment #8 looked the same as before this fix: ✓ ThinLinc Setup desktop shortcut icont ✓ Profile Chooser footer icon ✓ Header in tlclient login window ✓ Client desktop shortcut icon (different size used on macOS) ✓ Client icon for HP ThinPro connection wizard ✘ Client icon for thinstation packaging * ✓ Web Administration Interface desktop shortcut icon ✓ Web Administration Interface favicon ✓ Web Administration Interface header icon ✓ Web Administration Interface large icon on page 'Main/Home' ✓ Web Administration Interface system icons on page 'Status/Load' ✓ Web Access desktop shortcut icon ✓ Web Access login page favicon ✓ Web Access redirect page favicon * Web Access connected (noVNC) favicon ✓ Web Access iOS add-to-homescreen icon ✓ Web Access Chrome add-to-homescreen icon ✘ Web Access Firefox add-to-homescreen icon ** ✓ GNOME 3 symbolic top bar icon for all ThinLinc programs ✓ Sample login form icons in tlclient.cgi * This check was skipped since there is currently no machine to test thinstation on ** Firefox needs trusted certificates to allow favicon to work properly and to set up this up is too much work for only one thing. See bug 6058.
Checked the Makefile and the changes looked sane. I also tested regenerating all files and the only thing that changed was the embedded time stamps in the PNG files. LGTM.
