Bug 7407 - code signing certificates are about to expire
Summary: code signing certificates are about to expire
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Client platforms (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.12.0
Assignee: Samuel Mannehed
URL:
Keywords: ossman_tester, relnotes
Depends on:
Blocks:
 
Reported: 2019-10-23 12:28 CEST by Pierre Ossman
Modified: 2020-03-27 13:45 CET (History)
1 user (show)

See Also:
Acceptance Criteria:


Attachments
Log from Apple for the latest successful notarization of tlclient (16.35 KB, application/json)
2020-02-12 16:09 CET, Samuel Mannehed
Details
Log from Apple for a failed notarization of tlclient (11.22 KB, application/json)
2020-02-12 16:10 CET, Samuel Mannehed
Details
First part of the warning on Windows - you have to press "More info" (14.83 KB, image/png)
2020-02-21 10:55 CET, Samuel Mannehed
Details
The second part of the warning on Windows - after pressing "More info" it allows you to run the client (18.86 KB, image/png)
2020-02-21 10:56 CET, Samuel Mannehed
Details

Description Pierre Ossman cendio 2019-10-23 12:28:38 CEST
We have two certificates used for signing our client code; one for Windows and one for macOS. Both will expire next spring and need to be renewed.

The deadlines are Mar 12 for the macOS certificate, and May 22 for the Windows certificate.
Comment 3 Samuel Mannehed cendio 2020-02-12 16:09:20 CET
Created attachment 920 [details]
Log from Apple for the latest successful notarization of tlclient

Note that there are a number of warnings regarding "hardened runtime", "binary not signed", and "secure timestamp".
Comment 4 Samuel Mannehed cendio 2020-02-12 16:10:50 CET
Created attachment 921 [details]
Log from Apple for a failed notarization of tlclient

After updating to a new codesigning certificate the notarization step is failing. Note that the errors in the log are identical with the warnings we got in the latest successful notarization.

Signing the code works fine.
Comment 5 Samuel Mannehed cendio 2020-02-12 16:20:46 CET
Apparently, Apple have changed their notarization prerequisites since Feb 3 2020:

https://developer.apple.com/news/?id=12232019a
Comment 6 Samuel Mannehed cendio 2020-02-13 12:42:44 CET
The notarization problems have been moved to bug 7469.
Comment 8 Samuel Mannehed cendio 2020-02-21 10:55:02 CET
Created attachment 925 [details]
First part of the warning on Windows - you have to press "More info"

The new certificate triggers a warning on Windows. We have seen this before, it's likely that the warning will disappear after enough people have trusted it.
Comment 9 Samuel Mannehed cendio 2020-02-21 10:56:01 CET
Created attachment 926 [details]
The second part of the warning on Windows - after pressing "More info" it allows you to run the client
Comment 10 Samuel Mannehed cendio 2020-02-21 10:56:50 CET
We have decided to mention the Windows certificate warning in the release notes.
Comment 25 Samuel Mannehed cendio 2020-02-25 14:10:36 CET
Should be done now. Windows client signature is ready for testing, however the macOS client isn't due to bug 7469.
Comment 26 Pierre Ossman cendio 2020-02-27 09:31:56 CET
> +* The ThinLinc Client for Windows has gotten a new certificate. Windows

What certificate? What is it used for? I think it is more important to mention the function here.

> +  Defender SmartScreen will, during the first few weeks, show a warning
> +  until this new certificate has built enough trust with Microsoft's
> +  servers. (7407)

A few weeks from when? Perhaps just be vague and say that SmartScreen may complain without giving any details as to when this might happen.
Comment 28 Samuel Mannehed cendio 2020-02-27 10:22:51 CET
Relnotes are updated now.
Comment 29 Samuel Mannehed cendio 2020-03-02 15:20:54 CET
Since bug 7469 is done, this can be fully tested now.
Comment 30 Pierre Ossman cendio 2020-03-27 10:43:59 CET
Release notes look good.

Both certificates are renewed (check both PEM/DER and P12 formats).

Windows accepts the client and customizer installers signature and the certificates look fine. I did get the SmartScreen prompt though.

macOS will be tested on bug 7469.

Note You need to log in before you can comment on or make changes to this bug.