Bug 7247 - Windows registry parameters are limited to 255 characters or less
Summary: Windows registry parameters are limited to 255 characters or less
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Client (show other bugs)
Version: trunk
Hardware: PC Windows
: P2 Normal
Target Milestone: 4.10.0
Assignee: Peter Åstrand
URL:
Keywords: derfian_tester, relnotes
Depends on:
Blocks:
 
Reported: 2018-09-03 11:03 CEST by Peter Åstrand
Modified: 2018-09-10 13:06 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:
* The client should correctly handle registry values which are longer than 255 characters * Non-ASCII characters should still be handled correctly

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Peter Åstrand cendio 2018-09-03 11:03:08 CEST 
Currently, the ThinLinc client on Windows uses buffers when interacting with the registry which are limited to 255 UCS-2 and UTF-8 characters. If the retrieved value is longer than this, the parameter is silently ignored, and the client fallbacks to the hardcoded default.
Comment 6 Karl Mikaelsson cendio 2018-09-10 13:06:09 CEST 
> * The client should correctly handle registry values which are longer than 255 characters

Yes, tested with reading long (255<x<834 characters) HOST_ALIASES from registry and writing long NFS_EXPORTS to registry. (thinlinc-client-4.9.0post-5897)

> * Non-ASCII characters should still be handled correctly

Looks like they're still read and written okay.




Nitpick: I don't like having "correctly handle" in acceptance criteria, and this one used it in two out of two.
Note You need to log in before you can comment on or make changes to this bug.