Bug 7220 - Traceback in vsmagent.log due to unhandled exception
Summary: Traceback in vsmagent.log due to unhandled exception
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: VSM Agent (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.10.0
Assignee: Pierre Ossman
URL:
Keywords: derfian_tester, prosaic
Depends on:
Blocks:
 
Reported: 2018-08-10 15:22 CEST by Samuel Mannehed
Modified: 2018-08-14 09:28 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Samuel Mannehed cendio 2018-08-10 15:22:32 CEST 
When checking the config param allowed_clients in VSM agent it is possible to get an uncaught error:

> Traceback (most recent call last):
>   File "/opt/thinlinc/sbin/vsmagent", line 20, in <module>
>     VSMAgent ( sys . argv )
>   File "/opt/thinlinc/modules/thinlinc/vsm/vsmagent.py", line 133, in
> __init__
>     extra_hosts = Ii11iII1 )
>   File "/opt/thinlinc/modules/thinlinc/vsm/authoritychecker.py", line
> 20, in __init__
>     self . update_allowed_ips ( parent . hive . get_string_list (
> allowed_clients_hivepath , [ ] ) + extra_hosts )
>   File "/opt/thinlinc/modules/thinlinc/vsm/authoritychecker.py", line
> 26, in update_allowed_ips
>     oooO0oo0oOOOO = socket . gethostbyname_ex ( i1I1ii1II1iII ) [ 2 ]
> socket.herror: [Errno 0] Resolver Error 0 (no error)

This was actually seen in a customer logfile and I have not been able to reproduce this error myself.
Comment 3 Samuel Mannehed cendio 2018-08-10 16:26:19 CEST 
Should be fixed now.
Comment 4 Karl Mikaelsson cendio 2018-08-13 12:41:13 CEST 
Jenkins tests are failing.
Comment 9 Karl Mikaelsson cendio 2018-08-14 09:28:35 CEST 
Jenkins tests are passing again.

Additional unit tests has been added to cover when socket.gethostbyname_ex throws an socket.herror.
Note You need to log in before you can comment on or make changes to this bug.