Bug 7167 - ThinLinc client doesn't respect language settings on macOS
Summary: ThinLinc client doesn't respect language settings on macOS
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Client platforms (show other bugs)
Version: trunk
Hardware: Mac macOS
: P2 Normal
Target Milestone: 4.18.0
Assignee: Adam Halim
URL:
Keywords: ossman_tester, relnotes
Depends on:
Blocks:
 
Reported: 2018-05-03 10:45 CEST by Samuel Mannehed
Modified: 2024-11-15 16:13 CET (History)
5 users (show)

See Also:
Acceptance Criteria:
MUST: * tlclient on macOS must respect the OS language settings.


Attachments
Screenshot showing the issue (749.73 KB, image/png)
2018-05-03 11:01 CEST, Samuel Mannehed
Details

Description Samuel Mannehed cendio 2018-05-03 10:45:39 CEST
When setting a display language on macOS you can have multiple languages in a sorted list. The language at the top of the list is the primary language. All regular mac applications respect this setting and will always use the primary language.

The ThinLinc client however will always use the first non-english language in the list. To clarify, below follows 3 examples:

1. If the order of the language list is like this:

   * English (primary)
   * Swedish
   * French

   Our client will display in Swedish.

2. If the order is like this:

   * English (primary)
   * French
   * Swedish

   Our client will display in French.

3. If the order is like this:

   * Swedish (primary)
   * English
   * French

   Our client will display in Swedish.

The only way I found to get the ThinLinc client to display in English is if all other languages are removed completely from the list.

The effect of changing this setting is immediate and a reboot or logout inbetween does not change the behavior.
Comment 2 Samuel Mannehed cendio 2018-05-03 11:01:04 CEST
Created attachment 858 [details]
Screenshot showing the issue
Comment 3 Pierre Ossman cendio 2018-05-08 13:06:33 CEST
Another detail that makes this easier to occur:

If you add a keyboard layout then macOS tends to add the corresponding language as well. However you can then manually remove the language but keep the layout afterwards.
Comment 6 Calvin 2021-10-28 13:04:55 CEST
This issue still exists with 4.13.0 build 2172. 
Any solution or workaround so far?
Comment 7 Samuel Mannehed cendio 2021-10-28 16:18:48 CEST
I guess that you want the ThinLinc Client to display in English but want a different keyboard layout language?

As described in comment #3, the workaround in this case is to remove all non-English display languages but keep the keyboard languages needed.
Comment 8 Pierre Ossman cendio 2021-11-25 13:10:53 CET
Reported upstream:

https://www.cendio.com/bugzilla/show_bug.cgi?id=7167

Also noted in TigerVNC now that translations are working in their builds:

https://github.com/TigerVNC/tigervnc/issues/1381
Comment 9 Pierre Ossman cendio 2021-12-27 10:17:25 CET
(In reply to Pierre Ossman from comment #8)
> Reported upstream:
> 
> https://www.cendio.com/bugzilla/show_bug.cgi?id=7167
> 

This is of course the wrong link. The proper one is:

https://savannah.gnu.org/bugs/?61556
Comment 10 Pierre Ossman cendio 2021-12-27 10:17:55 CET
Upstream claims this is solved in 0.20.2 or later. We are currently using 0.19.3.
Comment 12 Kyle Rhorer 2022-08-20 13:58:00 CEST
Still an issue with the tl-4.14.0_2324 client freshly downloaded from the Cendio website on the date I'm writing this.
Comment 13 Adam Halim cendio 2024-10-31 15:08:29 CET
gettext has now been upgraded to 0.22.5 as part of bug 8402.

I tested the similar scenarios as in comment #1, and now the primary language is always used in the client.
Comment 15 Pierre Ossman cendio 2024-11-08 15:28:16 CET
I've checked the code changes and they look good.

I've also tried the command line tools:

 * Generate a new .pot file for upstream TigerVNC
 * Generate .mo files for upstream TigerVNC
 * Download ThinLinc translations from Transifex and run them through msgfilter
Comment 16 Pierre Ossman cendio 2024-11-11 16:07:58 CET
Something is broken on Windows. It no longer respects the system language in either the UI or on the start menu.
Comment 18 Adam Halim cendio 2024-11-12 17:29:49 CET
The issue was a patch that was re-applied incorrectly when gettext was upgraded. This has now been fixed.
Comment 19 Pierre Ossman cendio 2024-11-15 16:13:50 CET
Works well now. Tested on Windows 10, Fedora 39, and macOS 15. Currently configured language is respected in all cases.

Release notes look good.

Note You need to log in before you can comment on or make changes to this bug.