Bug 7126 - No animation for initial close of toolbar if it starts on the right side
Summary: No animation for initial close of toolbar if it starts on the right side
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Web Access (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.11.0
Assignee: Samuel Mannehed
URL:
Keywords: aleta_tester, prosaic, upstream
Depends on: 7365
Blocks:
  Show dependency tree / graph
 
Reported: 2018-03-08 16:04 CET by Samuel Mannehed
Modified: 2019-11-04 12:11 CET (History)
3 users (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Samuel Mannehed cendio 2018-03-08 16:04:44 CET 
The toolbar in Web Access shows briefly after connecting. If the user doesn't interact with the toolbar, it will automatically hide after 2 seconds.

The toolbar can be moved to either side, but as standard it appears on the left side. If a user has moved the toolbar to the right side, this preference will be saved to the browsers web storage, and this preference will be used for future Web Access sessions.

A bug prevents the animation from working for this first close of the toolbar. Subsequent opens and closes works fine.
Comment 3 Samuel Mannehed cendio 2018-03-08 16:59:16 CET 
Fix committed upstream: https://github.com/novnc/noVNC/commit/06309160ee25b7b99c96008f3d4d28933b097715
Comment 4 Niko Lehto cendio 2019-10-31 10:37:25 CET 
Tested after vendor drop (Build 6278) on:
* Windows 10 - IE 11, Edge 18, Chrome 78 and Firefox 70.

Works fine on these!
Comment 5 Alex Tanskanen cendio 2019-10-31 13:59:14 CET 
Verified this as well and it works fine on Windows 10 - IE 11, Edge 18, Chrome 78 and Firefox 70.
Note You need to log in before you can comment on or make changes to this bug.