Bug 7082 - Connecting using the Windows client takes unnecessarily long
Summary: Connecting using the Windows client takes unnecessarily long
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Client (show other bugs)
Version: trunk
Hardware: PC Windows
: P2 Normal
Target Milestone: 4.9.0
Assignee: Samuel Mannehed
Keywords: ossman_tester, relnotes
Depends on:
Reported: 2017-11-21 14:31 CET by Samuel Mannehed
Modified: 2017-11-22 13:02 CET (History)
1 user (show)

See Also:
Acceptance Criteria:


Description Samuel Mannehed cendio 2017-11-21 14:31:59 CET
When connecting, the ThinLinc client uses SSH to talk to the ThinLinc master (to get assigned to an agent). When this SSH connection is finished and the SSH process should be terminated we always wait 1.5 seconds for it to let us know that it has terminated properly. The SSH process will however never tell us that, leading to that we always waits 1.5 seconds in vein.
Comment 2 Samuel Mannehed cendio 2017-11-21 15:04:11 CET
Furthermore, the SSH process will not react to our message telling it to shut down cleanly, leading to that it always times out after 1.5 seconds. After the timeout a hard kill is performed on the process.
Comment 5 Samuel Mannehed cendio 2017-11-21 15:31:12 CET
The timeout that we always hit has now been removed. This makes the ThinLinc client connection 1.5 seconds faster on Windows.
Comment 6 Pierre Ossman cendio 2017-11-22 13:02:14 CET
Unfortunately the granularity of the log timestamp makes it difficult to perfectly test this, but it seems like we indeed have 1.5 seconds faster login.

Some comparisons:

 4.7.0: 3 seconds to killing SSH, 6 seconds to fully logged in
 4.9.0: 3 seconds to killing SSH, 5 seconds to fully logged in (1st test)
 4.9.0: 2 seconds to killing SSH, 4 seconds to fully logged in (2nd test)

Couldn't see any other problems. Other processes are still cleaned up properly, and nothing new gets a hard kill.

Note You need to log in before you can comment on or make changes to this bug.