Bug 7071 - VNC authentication failures aren't translated
Summary: VNC authentication failures aren't translated
Status: NEW
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: VNC (show other bugs)
Version: 1.3.1
Hardware: PC Unknown
: P2 Normal
Target Milestone: MediumPrio
Assignee: Pierre Ossman
Depends on:
Reported: 2017-10-25 10:11 CEST by Pierre Ossman
Modified: 2019-11-26 13:00 CET (History)
1 user (show)

See Also:
Acceptance Criteria:


Description Pierre Ossman cendio 2017-10-25 10:11:30 CEST
If something goes wrong during the VNC authentication phase, then the client will show an error string in English and not in the configured local language.

The problem is that the VNC protocol sends error strings rather than error codes in this case (see SecurityResult in the spec.). Historically these were rare so not much of an issue. However with bug 37 fixed these are more common as some shadowing errors will use this mechanism.

Possible fixes:

 - Translate the strings on the client. This should work well for us since it is a known server and therefore known strings. It is not a particularly good solution for upstream though.

 - Improve the protocol to send more error codes. There is a 32-bit field available so there is definitely space. We just need to coordinate things with other VNC implementations.

Note You need to log in before you can comment on or make changes to this bug.