Bug 7057 - rdesktop spams smart card errors under normal usage
Summary: rdesktop spams smart card errors under normal usage
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: | rdesktop (deprecated) (show other bugs)
Version: 1.3.1
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.9.0
Assignee: Karl Mikaelsson
URL:
Keywords: ossman_tester, prosaic
Depends on:
Blocks:
 
Reported: 2017-09-27 12:53 CEST by Pierre Ossman
Modified: 2017-12-29 16:48 CET (History)
2 users (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Pierre Ossman cendio 2017-09-27 12:53:31 CEST 
I get a constant stream of these when connected to rds11.lab.lkpg.cendio.se:

> SmartCard(error): TS_SCardGetStatusChange(), failed: (UNKNOWN ERROR) (0x8010000a)
> SmartCard(error): TS_SCardGetStatusChange(), failed: (UNKNOWN ERROR) (0x8010000a)
> SmartCard(error): TS_SCardGetStatusChange(), failed: (UNKNOWN ERROR) (0x8010000a)
> SmartCard(error): TS_SCardGetStatusChange(), failed: (UNKNOWN ERROR) (0x8010000a)
> SmartCard(error): TS_SCardGetStatusChange(), failed: (UNKNOWN ERROR) (0x8010000a)

0x8010000a is SCARD_E_TIMEOUT which is a perfectly sensible return code from SCardGetStatusChange(), so this should most likely not be logged.

Probably fallout from bug 5949, just like bug 7050.
Comment 1 Pierre Ossman cendio 2017-09-27 12:53:57 CEST 
This was with a Fedora 26 client which had a reader connected but no card in the reader.
Comment 2 Pierre Ossman cendio 2017-10-02 14:28:40 CEST 
Seems to be other return codes logged as well, just not constantly:

> SmartCard(error): TS_SCardGetStatusChange(), failed: (UNKNOWN ERROR) (0x80100002)
> SmartCard(error): TS_SCardConnect(), failed: (UNKNOWN ERROR) (0x8010000c)
Comment 3 Karl Mikaelsson cendio 2017-10-04 17:21:28 CEST 
https://github.com/rdesktop/rdesktop/pull/156
Comment 5 Karl Mikaelsson cendio 2017-10-10 15:58:37 CEST 
Found another problems when the client was disconnected:

> SmartCard(error): TS_SCardEstablishContext(), failed: (UNKNOWN ERROR) (0x8010001d)

0x8010001d means SCARD_E_NO_SERVICE: "The Smart card resource manager is not running.".
Comment 7 Pierre Ossman cendio 2017-10-16 13:15:38 CEST 
(In reply to comment #6)
>  - Refactoring rdpsnd to match specs
>  - Possibly improved audio sync

Audio seems to work no better or worse than before. So unfortunately no noticeable change to the sync issues. :/

Tested with Windows 2012 R2 and Windows 2016.

I also did not see any smart card messages whilst testing this, not even if I disconnected the ThinLinc session.
Comment 8 Karl Mikaelsson cendio 2017-10-17 11:21:30 CEST 
The smart card messages seems to be all gone now.
Comment 9 Pierre Ossman cendio 2017-10-23 13:34:19 CEST 
I double checked that we still had working smart cards by testing an Aventra in their application.
Note You need to log in before you can comment on or make changes to this bug.