Bug 6970 - ThinLinc uses "OS X", but the platform is now called "macOS"
Summary: ThinLinc uses "OS X", but the platform is now called "macOS"
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Other (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.10.0
Assignee: Samuel Mannehed
URL:
Keywords: ossman_tester, prosaic
Depends on:
Blocks:
 
Reported: 2017-05-10 16:26 CEST by Peter Åstrand
Modified: 2018-05-18 14:52 CEST (History)
3 users (show)

See Also:
Acceptance Criteria:


Attachments

Description Peter Åstrand cendio 2017-05-10 16:26:10 CEST
From:

https://en.wikipedia.org/wiki/Macintosh_operating_systems#Mac_OS_X.2FOS_X.2FmacOS

"macOS (originally named "Mac OS X" until 2012 and then "OS X" until 2016)[11] is the current Mac operating system that officially succeeded the classic Mac OS in 2001."

Our doc currently uses "OS X" in most places, and "MacOS" in some.
Comment 1 Samuel Mannehed cendio 2017-05-19 13:35:10 CEST
There are places outside of the documentation that needs to be updated as well. For example, the client-bundle folder is called "client-osx".
Comment 7 Samuel Mannehed cendio 2018-05-14 15:47:17 CEST
The documentation and website has been updated. Our code has also been updated for the most part to say "macOS" instead of "Mac OS X" or "OS X". The one main part I left out was the name of the build architecture "osx64".

I have verified that the macOS client builds and works well on macOS 10.13. I will let the nightly build run tonight and test signing the client tomorrow.
Comment 9 Samuel Mannehed cendio 2018-05-14 15:53:36 CEST
Had missed a spot in the documentation (MacOS->macOS).

Also note:

The client-bundle folder is now called client-macos and the .iso is now called tl-client-macos.iso.
Comment 11 Samuel Mannehed cendio 2018-05-15 16:50:39 CEST
(In reply to comment #7)
> I will let the nightly build run tonight and test signing the client tomorrow.

This works good as well. Resolving.
Comment 12 Pierre Ossman cendio 2018-05-16 10:41:42 CEST
Some minor things found:

 - The client linkkit still has a varible called OSX_LIBS
 - Our documentation in ctc/pki has some OS X references
 - Perhaps also change the code comments in tlclient?

Could not find any other bad naming in the tree worth changing. I also reviewed the commits and didn't see anything strange.
Comment 16 Samuel Mannehed cendio 2018-05-16 11:11:04 CEST
(In reply to comment #12)
> Some minor things found:
> 
>  - The client linkkit still has a varible called OSX_LIBS
>  - Our documentation in ctc/pki has some OS X references
>  - Perhaps also change the code comments in tlclient?

All fixed now.
Comment 17 Pierre Ossman cendio 2018-05-16 13:43:52 CEST
Looks good now.

Note You need to log in before you can comment on or make changes to this bug.