Bug 6351 - Bad colors in graphical installer and tlsetup in dark theme
Summary: Bad colors in graphical installer and tlsetup in dark theme
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Server Installer (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.13.0
Assignee: Samuel Mannehed
Keywords: prosaic, wilsj_tester
Depends on:
Reported: 2017-04-19 16:33 CEST by Samuel Mannehed
Modified: 2021-05-04 09:14 CEST (History)
2 users (show)

See Also:
Acceptance Criteria:

Screenshot of installer on Cinnamon with dark theme (96.40 KB, image/png)
2017-04-19 16:33 CEST, Samuel Mannehed

Description Samuel Mannehed cendio 2017-04-19 16:33:45 CEST
Created attachment 796 [details]
Screenshot of installer on Cinnamon with dark theme

In most gnome derivatives there is an option called "Use a dark theme variant when available". If this option is enabled in Cinnamon, the text on white background in our installer and tl-setup is too bright.
Comment 1 Samuel Mannehed cendio 2019-12-02 12:11:27 CET
This happens in GNOME on Fedora as well.
Comment 5 Samuel Mannehed cendio 2021-04-26 13:33:41 CEST
It turns out we force the background of some parts of tl-setup and tlinstaller to be white. If the user has a dark GTK theme the text in the theme will normally be light-grey or white. This caused the text to almost disappear on the white-background parts of tl-setup and tlinstaller.

This has now been fixed by forcing the text to be dark on those sections with a white background.
Comment 6 William Sjöblom cendio 2021-05-04 09:14:59 CEST
Tested on PopOS 20.04 LTS using the `Adwaita-dark' and `Pop-dark' themes against Jenkins server-bundle build #2033. All sections of tlinstaller and tl-setup where we override the theme background now also have their text color overridden correctly.

Note You need to log in before you can comment on or make changes to this bug.