Bug 6235 - remove_service calls systemctl incorrectly
Summary: remove_service calls systemctl incorrectly
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Other (show other bugs)
Version: 1.3.1
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.12.0
Assignee: Niko Lehto
URL:
Keywords: aleta_tester, prosaic
Depends on: 4290
Blocks:
  Show dependency tree / graph
 
Reported: 2017-04-13 12:41 CEST by Pierre Ossman
Modified: 2022-04-22 07:59 CEST (History)
3 users (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Pierre Ossman cendio 2017-04-13 12:41:01 CEST 
Broken in r31714 for bug 5794.

We get these when uninstalling ThinLinc packages:

> Unknown operation vsmagent.
> Unknown operation vsmserver.

The cause is the wrong order of arguments in remove_service:

>     /bin/systemctl ${service} disable

It should be:

>     /bin/systemctl disable ${service}

Not sure if there are any consequences besides the error.
Comment 1 Pierre Ossman cendio 2017-04-18 10:43:16 CEST 
(In reply to comment #0)
> Broken in r31714 for bug 5794.
> 

Actually bug 5974.
Comment 2 Niko Lehto cendio 2020-03-12 13:51:56 CET 
The changes done in r34910 (Part of Bug 4290) moves the functionality from remove_service file to where it is needed and also fixes the order of 
> /bin/systemctl ${service} disable
to
> /bin/systemctl disable ${service}

Could reproduce the issue with 4.11.0. Tested the fix with build 6415 on Ubuntu 18.04. Works fine.
Comment 3 Alex Tanskanen cendio 2020-03-16 16:12:32 CET 
Tested with build 6416 and was not able to reproduce this as I could with 4.11.0 so this is now fixed.
Note You need to log in before you can comment on or make changes to this bug.