The method handle_response() is used to send the response back in a XMLRPC handler once all processing is done. This name is rather confusing as all other methods with "handle" in the name are callbacks. Perhaps "send_response()" would be better.
This got fixed as part of bug 8224. handle_response() is now gone.
> MUST: > > * handle_response() should be replaced with a better named method/system ✓ > > SHOULD: > > * All XML-RPC API functions/method/properties should have sensible naming ✓ Looked through the commits, and with the conversion to asyncio, handle_response() has been removed/replaced with more sensible names. Closing as all acceptance criteria are met.
(In reply to Adam Halim from comment #7) > > MUST: > > > > * handle_response() should be replaced with a better named method/system ✓ > > > > SHOULD: > > > > * All XML-RPC API functions/method/properties should have sensible naming ✓ > > Looked through the commits, and with the conversion to asyncio, > handle_response() has been removed/replaced with more sensible names. > > Closing as all acceptance criteria are met. Note that the code was only reviewed and not tested extensively as the focus of this bug was code structure/readability. All parts that were changed will be tested more thoroughly when bug 8224 closes.
