Bug 6137 - fragile API for VSMXMLRPCCall
Summary: fragile API for VSMXMLRPCCall
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: VSM Server (show other bugs)
Version: 1.3.1
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.8.0
Assignee: Pierre Ossman
URL:
Keywords: prosaic, samuel_tester
Depends on:
Blocks:
 
Reported: 2017-01-13 13:33 CET by Pierre Ossman
Modified: 2017-03-20 16:54 CET (History)
2 users (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Pierre Ossman cendio 2017-01-13 13:33:33 CET 
VSMXMLRPCCall assumes that the attributes action, troubleaction and log are set up properly by the sub class. This is very easy to miss though so the API should be changed to enforce this better.

Discovered on bug 5489.
Comment 8 Pierre Ossman cendio 2017-01-16 15:19:54 CET 
Got some fallout from this bug, but it should be fixed now.
Comment 10 Samuel Mannehed cendio 2017-01-20 14:01:56 CET 
Code changes look good, tests pass, and I can't find any weird behavior when testing vsm communication with build 5350.
Note You need to log in before you can comment on or make changes to this bug.