Bug 6108 - Remove Esound support
Summary: Remove Esound support
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Sound (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.10.0
Assignee: Pierre Ossman
Keywords: relnotes, samuel_tester
Depends on:
Reported: 2016-12-14 09:22 CET by Peter Åstrand
Modified: 2019-02-14 16:31 CET (History)
2 users (show)

See Also:
Acceptance Criteria:
* No more esound traces left in the shipped product (except for the backwards compatibility fix in vsmserver) * Old clients should work fine with a new server * New client should work fine with old servers


Description Peter Åstrand cendio 2016-12-14 09:22:39 CET
Esound is a legacy sound system. We should consider removing our support for it: PulseAudio Esound module, tunnel ports etc. See also bug 6103.
Comment 1 Pierre Ossman cendio 2019-01-09 15:55:36 CET
Debian has now decided to remove esound from unstable. Fedora still includes it, but I can only find two applications requiring it: xarchon and moon-buggy; two ancient games.

It is now also causing problems for bug 7302, so perhaps it is time to nuke it.
Comment 2 Pierre Ossman cendio 2019-01-09 16:03:36 CET
As a note Fedora actually retired esound by mistake some years ago, and it seems it was the moon-buggy maintainer that got it restored:

Comment 3 Pierre Ossman cendio 2019-01-10 14:10:21 CET
It's not worth the effort trying to find more fixes. Let's just get this over with.
Comment 8 Pierre Ossman cendio 2019-01-15 13:27:51 CET
Works well. Had to do a backwards compatibility fix in vsmserver though. Unfortunately we had coded the client to require both an EsounD and PulseAudio tunnel and would refuse to use just one of them. So we add a dummy EsounD the same way we do for lpd for shadowing (also to handle older clients).
Comment 9 Samuel Mannehed cendio 2019-02-13 16:14:02 CET
Verified that both client build 6040 and a 4.6.0 client works well with audio playback against a server build 6040 on Fedora 29.

The 4.6.0 client warns in the log:

"2019-02-13T16:07:53: ssh[E]: Warning: remote port forwarding failed for listen port 1"

Commits also look good, +1 for tests. Can't find anything left in the tree that should be removed.
Comment 10 Samuel Mannehed cendio 2019-02-14 16:31:45 CET
Also verified that audio redirection works well with a client build 6040 against a 4.9.0 server.

Note You need to log in before you can comment on or make changes to this bug.