Bug 6055 - Pressing SPACE toggles toolbar buttons in IE and Edge
Summary: Pressing SPACE toggles toolbar buttons in IE and Edge
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Web Access (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.11.0
Assignee: Samuel Mannehed
Keywords: focus_focus, nikle_tester, relnotes, upstream
Depends on: 7365
Blocks: 5780
  Show dependency treegraph
Reported: 2016-10-13 13:27 CEST by Samuel Mannehed
Modified: 2019-11-06 09:52 CET (History)
3 users (show)

See Also:
Acceptance Criteria:


Description Samuel Mannehed cendio 2016-10-13 13:27:55 CEST
Found using IE 11 and Edge 38. Can reproduce using both ThinLinc 4.6 and 4.7 rc2, so this is not a regression.

Description of bug:

After you have used any button in the toolbar in the HTML5 client SPACE will, when pressed, toggle that button in the toolbar. It continues to happen even after you have used the mouse inside the session. It only stops happening if you click somewhere outside any button in the toolbar, or if you click on any element that belongs to the browser GUI.

Steps to reproduce:

1. Login using the HTML5 client in IE or Edge
2. Use any button in the controlbar, for example to toggle the extra keys
3. press space

Expected behavior:

Any ThinLinc HTML5 client interface shouldn't react to keyboard input except for when focusing the clipboard text area.

Actual behavior:

Even though the SPACE is being sent to the server, the toolbar buttons are still being toggled.
Comment 1 Samuel Mannehed cendio 2016-10-13 13:57:08 CEST
This bug does not apply to the new toolbar-handle in 4.7.
Comment 2 Pierre Ossman cendio 2016-10-18 11:04:42 CEST
This does not happen on mobile devices.
Comment 3 Samuel Mannehed cendio 2016-10-24 15:10:15 CEST
Comment 4 Samuel Mannehed cendio 2017-10-23 13:55:25 CEST
Fixed upstream!

Comment 5 Samuel Mannehed cendio 2017-10-23 13:57:54 CEST
Moved from "Next" to "---" for discussion.
Comment 6 Niko Lehto cendio 2019-10-31 12:15:28 CET
Tested after vendor drop (Build 6278) on:
* Windows 10 - IE 11 and Edge 18

Could not reproduce this issue in eudemo using Edge. I could reproduce it in eudemo using IE though.

This issue is now fixed with this vendor drop!
Comment 8 Alex Tanskanen cendio 2019-11-06 09:52:27 CET
Checked release notes and it looks good!

Note You need to log in before you can comment on or make changes to this bug.