Found using IE 11 and Edge 38. Can reproduce using both ThinLinc 4.6 and 4.7 rc2, so this is not a regression. Description of bug: After you have used any button in the toolbar in the HTML5 client SPACE will, when pressed, toggle that button in the toolbar. It continues to happen even after you have used the mouse inside the session. It only stops happening if you click somewhere outside any button in the toolbar, or if you click on any element that belongs to the browser GUI. Steps to reproduce: 1. Login using the HTML5 client in IE or Edge 2. Use any button in the controlbar, for example to toggle the extra keys 3. press space Expected behavior: Any ThinLinc HTML5 client interface shouldn't react to keyboard input except for when focusing the clipboard text area. Actual behavior: Even though the SPACE is being sent to the server, the toolbar buttons are still being toggled.
This bug does not apply to the new toolbar-handle in 4.7.
This does not happen on mobile devices.
https://github.com/kanaka/noVNC/issues/692
Fixed upstream! https://github.com/novnc/noVNC/pull/916
Moved from "Next" to "---" for discussion.
Tested after vendor drop (Build 6278) on: * Windows 10 - IE 11 and Edge 18 Could not reproduce this issue in eudemo using Edge. I could reproduce it in eudemo using IE though. This issue is now fixed with this vendor drop!
Checked release notes and it looks good!
