Comment 1 Pierre Ossman 2016-10-11 11:20:23 CEST

Handing over to product council for a decision on what to do.

Comment 2 Pierre Ossman 2016-10-13 15:14:42 CEST

Sent a mail to thinlinc-technical to see if anyone uses this feature:

http://lists.cendio.se/pipermail/thinlinc-technical/2016-October/005801.html

Comment 3 Pierre Ossman 2016-11-15 13:14:03 CET

All feedback we've gotten is that noone is using this. We can go ahead and remove the feature.

Comment 5 Pierre Ossman 2025-04-16 17:02:15 CEST

This is causing issues with the upgrade of gcc (bug 8361) since the sercd and cyclades code is so old.

Let's remove these rather than spend significant effort fixing them.

Comment 9 Pierre Ossman 2025-04-17 10:37:22 CEST

> MUST:
> 
>  * A client with serial support should work against a server without it, albeit without serial port support

Seems to work. Tested from a Fedora client against a RHEL 10 beta server. No complaints in the client log.

>  * A client without serial support should work against a server with it

Also seems to work. Tested from a Fedora client against a RHEL 9 server. No complaints in client log, or xinit.log. Also ran tl-serial-redir.sh which started things without complaint.

> SHOULD:
> 
>  * Everything supporting only serial ports should be removed from the ThinLinc and cenbuild sources

As far as I can find. There was an incorrect comment in tlclient that I left alone.

>  * No longer relevant Bugzilla entries should be closed

Everything should be closed as WONTFIX now. I've also marked the component as deprecated.

Comment 11 Adam Halim 2025-04-22 12:19:52 CEST

Tested a RHEL 9 server with build 4009, and server 4.18.0 on Ubuntu 24.04.

Clients were tested on Fedora 40, with build 3900 and 4.18.0.

With a new client and 4.18.0 server, I did not see any issues with running
> source /opt/thinlinc/libexec/tl-serial-redir.sh
With a 4.18.0 client with serial ports enabled, and a 4.18.0 server, sourcing
tl-serial-redir.sh worked as expected and I could see my serial port forwarded
to the server. Note that I did not have a real serial port device connected to
my machine and could not verify that it actually worked.

Using a 4.18.0 client with serial ports enabled, and server build 4009, I could see the following in the client log:
> Server did not specify serial tunnel port. Serial port will be disabled.
Everything seems to be in order.

I've looked through the commits and they look good.

grep:ed after "serial" in the source tree and, as mentioned in
comment #9, there are some incorrect comments referencing serial ports, but no
actual code related to it.

> MUST:
>  * A client with serial support should work against a server without it, albeit without serial port support
>  * A client without serial support should work against a server with it
Indeed, everything works as I would expect.
> SHOULD:
>  * Everything supporting only serial ports should be removed from the ThinLinc and cenbuild sources
Seems like it.
>  * No longer relevant Bugzilla entries should be closed
I did not find any open entries related to serial ports.