Bug 5980 - tl-setup's lsb step installs more than necessary
Summary: tl-setup's lsb step installs more than necessary
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Server Installer (show other bugs)
Version: 1.3.1
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.13.0
Assignee: Pierre Ossman
URL:
Keywords: prosaic, samuel_tester
Depends on: 5985
Blocks: 7716
  Show dependency treegraph
 
Reported: 2016-09-09 11:29 CEST by Pierre Ossman
Modified: 2021-08-24 12:29 CEST (History)
4 users (show)

See Also:
Acceptance Criteria:


Attachments

Description Pierre Ossman cendio 2016-09-09 11:29:38 CEST
The "essential commands" step in tl-setup tries to install all it's dependencies no matter which happens to be missing. This can cause some weird behaviour like doing upgrades of some seemingly unrelated package.

We should check the list of missing commands and only add the necessary packages.
Comment 1 Pierre Ossman cendio 2016-09-13 10:54:41 CEST
The essential step has been merged with the lsb step.
Comment 3 Pierre Ossman cendio 2021-07-20 12:43:25 CEST
Fixed now and tested on Ubuntu 20.04. I manually installed lsb-invalid-mta and tl-setup did not try to replace it with default-mta when installing other basic requirements (ghostscript, nss and nspr were missing).
Comment 4 William Sjöblom cendio 2021-08-13 15:53:36 CEST
A couple of notes on testing:

This fix is actually a rollback of a workaround (r31692) for bug 5985 (that
has now been fixed and remains to be tested). The only binary that has
multiple providers on the major distributions is /usr/bin/sendmail. gs,
ss, pgrep, and xauth have single providing packages. So if, for example,
lsb-invalid-mta is installed, default-mta is not to be installed by tl-setup
since lsb-invalid-mta provides /usr/sbin/sendmail.

The binaries that we are installing are:
- gs
- ss
- pgrep
- /usr/sbin/sendmail
- xauth

For testing this bug we need to verify that *only* missing binaries of the
above are installed by tl-setup, along the lines of what is described in
comment 3.
Comment 5 Samuel Mannehed cendio 2021-08-24 11:13:45 CEST
Tested alongside bug 5985, things look good in both text and gui mode on openSUSE Leap 15.3, Fedora 34, RHEL 7 and Ubuntu 18.04.

The installed packages look sane. For sendmail postfix was installed on ubuntu, RHEL and Fedora. On openSUSE I had to manually install that requirement.
Comment 6 Samuel Mannehed cendio 2021-08-24 12:29:47 CEST
Used the tl-4.13.0rc2 server for testing.

Note You need to log in before you can comment on or make changes to this bug.