Bug 5965 - Remove async.format_exc compatibility function
Summary: Remove async.format_exc compatibility function
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Other (show other bugs)
Version: 4.6.0
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.8.0
Assignee: Karl Mikaelsson
Keywords: ossman_tester, prosaic
Depends on:
Reported: 2016-08-25 09:40 CEST by Karl Mikaelsson
Modified: 2017-03-20 16:54 CET (History)
1 user (show)

See Also:
Acceptance Criteria:


Description Karl Mikaelsson cendio 2016-08-25 09:40:34 CEST
async.format_exc was written when we had to support Python versions older than 2.4. For Python 2.4 and above, the function is a thin wrapper around traceback.format_exc.

Given that we now require Python 2.4, we should remove this compatibility function and change calling code to use traceback.format_exc instead.

This avoids us having compatibility code for stuff we don't support any longer and avoiding odd dependencies across modules - async isn't the most obvious place to put compatibility code.
Comment 4 Karl Mikaelsson cendio 2016-12-06 13:56:53 CET
I believe I am done with this bug now.

(All tests were performed with thinlinc-4.7.0post-5309)

Autotests should catch any problems with the VSM code, and they're all passing.

I've manually tested the print_exc -> format_exc changes by modifying a nightly build to raise exceptions in pages (tlwebadm, tlwebaccess), and by running tlclient.cgi by hand in a terminal, which triggers the changed code path.
Comment 5 Pierre Ossman cendio 2016-12-07 13:27:09 CET
I can not find any place that has been overlooked. I also reviewed the code and did some tests by injecting errors in to the code to make it crash. Everything looks correct.

Note You need to log in before you can comment on or make changes to this bug.