Bug 5958 - vncviewer crashes on Windows for CRLF clipboard
Summary: vncviewer crashes on Windows for CRLF clipboard
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Build system (show other bugs)
Version: pre-1.0
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.7.0
Assignee: Pierre Ossman
URL:
Keywords: hean01_tester, prosaic
Depends on:
Blocks:
 
Reported: 2016-08-16 15:07 CEST by Pierre Ossman
Modified: 2016-09-23 10:08 CEST (History)
2 users (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Pierre Ossman cendio 2016-08-16 15:07:46 CEST 
There is a bug in FLTK that causes vncviewer on Windows to crash when it receives clipboard data containing CRLF line endings[1]. The problem is a bad for loop that causes buffer overflows.

[1] These are technically a RFB protocol violation, but we are not filtering or enforcing this properly
Comment 3 Henrik Andersson cendio 2016-08-17 16:32:11 CEST 
Verified that chavez builds out client with fltk-1.3.3-8
Comment 4 Henrik Andersson cendio 2016-08-18 09:59:04 CEST 
Verified that i could reproduce the crash with 4.6.0 client and that it clipboard is working as expected using build 5208 on the windows platform.
Note You need to log in before you can comment on or make changes to this bug.