Bug 5868 - unit tests should be primarily (exclusively?) targeting working copy
Summary: unit tests should be primarily (exclusively?) targeting working copy
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Automatic tests (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.10.0
Assignee: Karl Mikaelsson
URL:
Keywords: prosaic
Depends on:
Blocks:
 
Reported: 2016-05-02 13:52 CEST by Pierre Ossman
Modified: 2018-08-21 13:05 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Pierre Ossman cendio 2016-05-02 13:52:47 CEST 
Our unit tests right now are primarily built to be run against an installed copy of ThinLinc. This is probably not a good approach as it discourages using them actively during development.

Bug 5865 might also be relevant to this as that might move the unit tests closer to the code they're testing.
Comment 1 Pierre Ossman cendio 2016-05-03 11:13:23 CEST 
We've decided that we do indeed want the unit tests to target the working copy rather than the installed code. A first step is updating the scout rules on the intranet with this fact.

Actually fixing the existing tests can be done piecewise, perhaps whilst we are moving them as part of bug 5865.
Comment 2 Karl Mikaelsson cendio 2016-05-11 09:26:59 CEST 
(In reply to comment #1)
> We've decided that we do indeed want the unit tests to target the working copy
> rather than the installed code. A first step is updating the scout rules on the
> intranet with this fact.

A scout rule has been written.

https://intranet.lkpg.cendio.se/ThinLinc/Scoutregler
Comment 3 Pierre Ossman cendio 2018-08-21 13:05:02 CEST 
We've done this for the unit tests for VSM, but there are a few more left. However let's handle the move of those on bug 5865.
Note You need to log in before you can comment on or make changes to this bug.