Bug 5834 - tlclient fails to start when any line in configuration file exceeds 1020 characters
Summary: tlclient fails to start when any line in configuration file exceeds 1020 char...
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Client (show other bugs)
Version: 4.5.0
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.9.0
Assignee: Karl Mikaelsson
URL:
Keywords: hean01_tester, relnotes
Depends on:
Blocks:
 
Reported: 2016-04-04 14:25 CEST by Karl Mikaelsson
Modified: 2017-08-21 16:25 CEST (History)
2 users (show)

See Also:
Acceptance Criteria:


Attachments

Description Karl Mikaelsson cendio 2016-04-04 14:25:57 CEST
We got a report from a customer that a server name configuration with a lot of trailing periods make tlclient unable to start. I've been able to reproduce and found that tlclient seems to spend a lot of time in ConfigMap::LoadFile when it encounters a long line.
Comment 6 Karl Mikaelsson cendio 2017-08-15 13:20:32 CEST
Tested on Linux, Windows and OS X with configuration files with lines exceeding 1020 characters.
Comment 8 Henrik Andersson cendio 2017-08-21 13:17:29 CEST
Inspected and ran the unit tests, looks all good to me.
Comment 9 Henrik Andersson cendio 2017-08-21 16:25:58 CEST
Verified on Windows 10, Fedora 26 and Mac OSX. Works as expected.

Note You need to log in before you can comment on or make changes to this bug.