Bug 5810 - possible incorrect shadow notification on reconnect
Summary: possible incorrect shadow notification on reconnect
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Other (show other bugs)
Version: pre-1.0
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.9.0
Assignee: Henrik Andersson
URL:
Keywords: focus_shadowing, ossman_tester, relnotes
Depends on:
Blocks:
 
Reported: 2016-02-26 12:39 CET by Pierre Ossman
Modified: 2017-10-24 09:46 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Pierre Ossman cendio 2016-02-26 12:39:36 CET 
Bug 2251 gave us the ability to tell shadowers and "normal" connections apart. This give us the option to fix this corner case:

 1. A user starts a session and connects

 2. A shadower connects and a notification pops up (CORRECT)

 3. The user disconnects, but the shadower remains.

 4. The user reconnects an a notification pops up (INCORRECT)

This is because we merely look at the number of the connections right now, not their type.
Comment 1 Karl Mikaelsson cendio 2016-02-29 11:12:56 CET 
Is this a duplicate of bug 5737?
Comment 2 Karl Mikaelsson cendio 2016-03-01 15:33:16 CET 
Consider getting rid of connection counting altogether and only rely on the shadower connection event to trigger a warning. While it would not get rid of the race, it would make it less likely to happen.
Comment 3 Pierre Ossman cendio 2017-10-24 09:43:27 CEST 
This got fixed as part of bug 37/bug 5737.
Note You need to log in before you can comment on or make changes to this bug.