Bug 5804 - incorrect PKG_CONFIG_PATH set for cenbuild
Summary: incorrect PKG_CONFIG_PATH set for cenbuild
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Build system (show other bugs)
Version: pre-1.0
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.6.0
Assignee: Henrik Andersson
URL:
Keywords: prosaic, samuel_tester
Depends on:
Blocks: 2776
  Show dependency treegraph
 
Reported: 2016-02-23 14:55 CET by Pierre Ossman
Modified: 2016-04-01 11:10 CEST (History)
2 users (show)

See Also:
Acceptance Criteria:


Attachments

Description Pierre Ossman cendio 2016-02-23 14:55:47 CET
rpmbuild implicitly injects this before all stages in the rpm build:

  PKG_CONFIG_PATH="${PKG_CONFIG_PATH}:%{_libdir}/pkgconfig:%{_datadir}/pkgconfig"

This can cause problems for us, in particular for the cross-compile builds. They can then end up looking at the native pkg-config files rather than the cross-compile ones.

This variable is set in %___build_pre. Unfortunately there doesn't seem to be any good abstraction for us to override this, so it looks like we'll have to redefine %___build_pre.
Comment 2 Samuel Mannehed cendio 2016-03-18 09:45:43 CET
I built cendio-build-utils from a repo on a revision before the fix. I downgraded my cendio-build-utils package to the one that I built. I then added echo $PKG_CONFIG_PATH to a .spec-file and ran rpmbuild on it:

+ echo :/usr/lib64/pkgconfig:/usr/share/pkgconfig
:/usr/lib64/pkgconfig:/usr/share/pkgconfig

I then updated cendio-build-utils to the latest version and then ran rpmbuild on the same spec-file:

+ unset PKG_CONFIG_PATH
+ unset PKG_CONFIG_PATH
+ echo

Looks good!

Note You need to log in before you can comment on or make changes to this bug.