Bug 5801 - bad placement of thinlinc.vsm.lowxmlrpc in source/install tree
Summary: bad placement of thinlinc.vsm.lowxmlrpc in source/install tree
Status: CLOSED WORKSFORME
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Other (show other bugs)
Version: 4.5.0
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.15.0
Assignee: Bugzilla mail exporter
URL:
Keywords:
Depends on:
Blocks: 217 571
  Show dependency tree / graph
 
Reported: 2016-02-11 15:48 CET by Karl Mikaelsson
Modified: 2023-06-13 13:33 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Karl Mikaelsson cendio 2016-02-11 15:48:01 CET 
Nothing in vsm uses anything from lowxmlrpc, so we could as well move it to tlprinter, where it's used. Nothing else in the ctc tree seems to use it.

> derfian@aperture:~/src/thinlinc $ git grep lowxmlrpc
> printer/modules/thinlinc/tlprinter.py:from thinlinc.vsm.lowxmlrpc import LowPortServerProxy
> vsm/Makefile:   $(OINSTALL) -m 644 modules/thinlinc/vsm/lowxmlrpc.py $(VSMMOD)/
Comment 1 Pierre Ossman cendio 2016-02-16 10:54:10 CET 
tlprinter is probably a bit specific as this is more general code than that (even though only tlprinter uses it right now). Some common area would probably be a better fit.

This bug might also be handled as part of bug 571, or made obsolete by bug 217.
Comment 2 Pierre Ossman cendio 2023-06-13 13:33:39 CEST 
This got fixed in r35749 for bug 7554.
Note You need to log in before you can comment on or make changes to this bug.