Bug 5754 - use nettle in Xvnc instead of openssl
Summary: use nettle in Xvnc instead of openssl
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: VNC (show other bugs)
Version: pre-1.0
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.10.0
Assignee: Pierre Ossman
URL:
Keywords: prosaic
Depends on:
Blocks:
 
Reported: 2015-12-16 13:31 CET by Pierre Ossman
Modified: 2019-02-18 13:55 CET (History)
1 user (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Pierre Ossman cendio 2015-12-16 13:31:32 CET 
Xvnc (via the xorg sources) needs SHA-1 routines and it can grab these from many different libraries. The default is OpenSSL, and that's what we're currently using.

nettle is however a much smaller and cleaner option when you just want one of the crypto algorithms. And we already have nettle in the build environment. So we should look at switching over.
Comment 4 Pierre Ossman cendio 2019-02-13 14:10:40 CET 
Patch applied now. Tested text rendering, as that is what the server uses the crypto for. Could not see any issues.
Comment 5 Peter Åstrand cendio 2019-02-18 13:55:50 CET 
Tested Xvnc from build thinlinc-vnc-server-4.9.0post-6045.x86_65. It contains nettle strings, but no OpenSSL strings like before. Works good.
Note You need to log in before you can comment on or make changes to this bug.